From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Hu Ziji <huziji@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-xenon: mark expected switch fall-through
Date: Thu, 5 Jul 2018 15:09:18 +0200 [thread overview]
Message-ID: <CAPDyKFrQEnA4jYH4cVBq1-AFHWKHKuXSh63M1f0XVyi-7h53Rw@mail.gmail.com> (raw)
In-Reply-To: <20180703225659.GA14443@embeddedor.com>
On 4 July 2018 at 00:56, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Warning level 2 was used: -Wimplicit-fallthrough=2
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-xenon-phy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c
> index a35804b..c335052 100644
> --- a/drivers/mmc/host/sdhci-xenon-phy.c
> +++ b/drivers/mmc/host/sdhci-xenon-phy.c
> @@ -526,6 +526,7 @@ static bool xenon_emmc_phy_slow_mode(struct sdhci_host *host,
> ret = true;
> break;
> }
> + /* else: fall through */
> default:
> reg &= ~XENON_TIMING_ADJUST_SLOW_MODE;
> ret = false;
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-07-05 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 22:56 [PATCH] mmc: sdhci-xenon: mark expected switch fall-through Gustavo A. R. Silva
2018-07-05 13:09 ` Ulf Hansson [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-12 15:25 [PATCH] mmc: sdhci-xenon: Mark " Gustavo A. R. Silva
2019-02-13 8:35 ` Ulf Hansson
2019-02-13 18:13 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrQEnA4jYH4cVBq1-AFHWKHKuXSh63M1f0XVyi-7h53Rw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=gustavo@embeddedor.com \
--cc=huziji@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).