* [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA
@ 2015-11-09 9:36 Geert Uytterhoeven
2015-11-09 12:43 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-11-09 9:36 UTC (permalink / raw)
To: Ulf Hansson
Cc: Luis de Bethencourt, linux-mmc, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined!
ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
ERROR: dma_map_sg [drivers/mmc/host/android-goldfish.ko] undefined!
ERROR: dma_free_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mmc/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index af71de5fda3b48c9..1dee533634c986d7 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -473,6 +473,7 @@ config MMC_DAVINCI
config MMC_GOLDFISH
tristate "goldfish qemu Multimedia Card Interface support"
+ depends on HAS_DMA
depends on GOLDFISH || COMPILE_TEST
help
This selects the Goldfish Multimedia card Interface emulation
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA
2015-11-09 9:36 [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA Geert Uytterhoeven
@ 2015-11-09 12:43 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2015-11-09 12:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Luis de Bethencourt, linux-mmc, linux-kernel@vger.kernel.org
On 9 November 2015 at 10:36, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If NO_DMA=y:
>
> ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined!
> ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
> ERROR: dma_map_sg [drivers/mmc/host/android-goldfish.ko] undefined!
> ERROR: dma_free_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index af71de5fda3b48c9..1dee533634c986d7 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,6 +473,7 @@ config MMC_DAVINCI
>
> config MMC_GOLDFISH
> tristate "goldfish qemu Multimedia Card Interface support"
> + depends on HAS_DMA
> depends on GOLDFISH || COMPILE_TEST
> help
> This selects the Goldfish Multimedia card Interface emulation
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-09 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-09 9:36 [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA Geert Uytterhoeven
2015-11-09 12:43 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).