From: Ulf Hansson <ulf.hansson@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jisheng Zhang <jszhang@kernel.org>,
linux-mmc@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv2 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support
Date: Wed, 9 Nov 2022 13:34:15 +0100 [thread overview]
Message-ID: <CAPDyKFrwgu2zdju72d7ftKDn3UJHsthmfav9zf3FQjs-aMgz-g@mail.gmail.com> (raw)
In-Reply-To: <20221107173310.60503-1-sebastian.reichel@collabora.com>
On Mon, 7 Nov 2022 at 18:33, Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Properly describe reset related properties in the binding.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Changes since PATCHv1:
> * https://lore.kernel.org/all/20221021171654.87071-1-sebastian.reichel@collabora.com/
> * dropped minItems (Krzysztof Kozlowski)
> * reset-names are not copy pasted and intentionally the same as
> the clock-names. DT looks like this:
>
> clocks = <&cru CCLK_EMMC>, <&cru HCLK_EMMC>,
> <&cru ACLK_EMMC>, <&cru BCLK_EMMC>,
> <&cru TMCLK_EMMC>;
> clock-names = "core", "bus", "axi", "block", "timer";
> resets = <&cru SRST_C_EMMC>, <&cru SRST_H_EMMC>,
> <&cru SRST_A_EMMC>, <&cru SRST_B_EMMC>,
> <&cru SRST_T_EMMC>;
> reset-names = "core", "bus", "axi", "block", "timer";
> ---
> .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 71f8e726d641..51ba44cad842 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -45,6 +45,17 @@ properties:
> - const: block
> - const: timer
>
> + resets:
> + maxItems: 5
> +
> + reset-names:
> + items:
> + - const: core
> + - const: bus
> + - const: axi
> + - const: block
> + - const: timer
> +
> rockchip,txclk-tapnum:
> description: Specify the number of delay for tx sampling.
> $ref: /schemas/types.yaml#/definitions/uint8
> --
> 2.35.1
>
prev parent reply other threads:[~2022-11-09 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 17:33 [PATCHv2 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support Sebastian Reichel
2022-11-07 18:07 ` Krzysztof Kozlowski
2022-11-09 12:34 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrwgu2zdju72d7ftKDn3UJHsthmfav9zf3FQjs-aMgz-g@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).