From: "Ricardo B. Marlière" <ricardo@marliere.net>
To: "Erick Shepherd" <erick.shepherd@ni.com>, <linux-kernel@vger.kernel.org>
Cc: <linux-mmc@vger.kernel.org>, <ulf.hansson@linaro.org>,
<adrian.hunter@intel.com>, <avri.altman@wdc.com>,
<wsa+renesas@sang-engineering.com>, <quic_jjohnson@quicinc.com>,
<andy-ld.lu@mediatek.com>, <victor.shih@genesyslogic.com.tw>,
<keita.aihara@sony.com>, <dsimic@manjaro.org>,
<cw9316.lee@samsung.com>
Subject: Re: [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return errors
Date: Thu, 06 Feb 2025 19:34:52 -0300 [thread overview]
Message-ID: <D7LPZ1L5CJLC.3CZRIDER6UHSO@marliere.net> (raw)
In-Reply-To: <20250206210835.2980500-1-erick.shepherd@ni.com>
On Thu Feb 6, 2025 at 6:08 PM -03, Erick Shepherd wrote:
> Updates the sdhci_execute_tuning function to return the error code
> that was returned by the __sdhci_execute_tuning function.
> Previously this code was only stored in host->tuning_err and not
> actually returned.
>
> Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
> ---
> drivers/mmc/host/sdhci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index f4a7733a8ad2..b35b8917fa1e 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2967,7 +2967,8 @@ int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
>
> sdhci_start_tuning(host);
>
> - host->tuning_err = __sdhci_execute_tuning(host, opcode);
> + err = __sdhci_execute_tuning(host, opcode);
> + host->tuning_err = err;
Reviewed-by: Ricardo B. Marlière <ricardo@marliere.net>
>
> sdhci_end_tuning(host);
> out:
next prev parent reply other threads:[~2025-02-06 22:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 21:08 [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return errors Erick Shepherd
2025-02-06 21:08 ` [RFC PATCH V2 2/2] mmc: allow card to disable tuning Erick Shepherd
2025-02-15 1:08 ` Adrian Hunter
2025-02-18 18:41 ` Erick Shepherd
2025-03-06 14:01 ` Adrian Hunter
2025-03-07 17:45 ` Erick Shepherd
2025-03-07 18:44 ` Adrian Hunter
2025-03-07 21:17 ` Erick Shepherd
2025-03-11 15:20 ` Adrian Hunter
2025-03-13 16:32 ` Erick Shepherd
2025-02-06 22:34 ` Ricardo B. Marlière [this message]
2025-02-15 1:05 ` [RFC PATCH V2 1/2] mmc: Update sdhci tune function to return errors Adrian Hunter
2025-02-18 18:41 ` Erick Shepherd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7LPZ1L5CJLC.3CZRIDER6UHSO@marliere.net \
--to=ricardo@marliere.net \
--cc=adrian.hunter@intel.com \
--cc=andy-ld.lu@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=cw9316.lee@samsung.com \
--cc=dsimic@manjaro.org \
--cc=erick.shepherd@ni.com \
--cc=keita.aihara@sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox