Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: "Philipp Jonas" <pjjonas@web.de>
To: "Sean Rhodes" <sean@starlabs.systems>, "Philipp Jonas" <pjjonas@web.de>
Cc: "Thorsten Leemhuis" <regressions@leemhuis.info>,
	<linux-mmc@vger.kernel.org>, <regressions@lists.linux.dev>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ulf Hansson" <ulfh@kernel.org>
Subject: Re: [REGRESSION] rtsx_usb_sdmmc: RTS5129 (0bda:0129) no longer detects SD card
Date: Fri, 20 Nov 2026 15:43:54 +0100	[thread overview]
Message-ID: <DN049N2EXDXT.30B93GJPIZN9S@web.de> (raw)
In-Reply-To: <CABtds-0DNu1HP1M5qf34SWEMoYW3i9jkNxOYg5+7gywGU01nwg@mail.gmail.com>

On Thu Nov 19, 2026 at 11:10 PM CET, Sean Rhodes wrote:
> Hi
>
> Thanks - I don't have any cards that old to test with, but the attached
> should work (borrowed from the old driver that was removed)
>
> Sean
>
> On Thu, 19 Nov 2026 at 18:53, Philipp Jonas <pjjonas@web.de> wrote:
>
>> On Thu Nov 19, 2026 at 3:35 PM CET, Sean Rhodes wrote:
>> > Hi
>> >
>> > Could you share the trace from a failing 7.3.4? And what card was it?
>> >
>> > Thanks
>> >
>> > Sean
>> >
>> > On Sat, 14 Nov 2026 at 20:54, Philipp Jonas <pjjonas@web.de> wrote:
>> >
>> >> On Wed Nov 11, 2026 at 10:06 AM CET, Thorsten Leemhuis wrote:
>> >> > On 11/8/26 19:51, Philipp wrote:
>> >> >>
>> >> >> the SD card in the internal Realtek RTS5129 USB card reader
>> >> >> (0bda:0129) of my Lenovo V110-15IKB is no longer detected.
>> >> >>
>> >> >> Works:  6.12.116, 7.2.x
>> >> >> Broken: 6.18.x, 7.3.3
>> >> >>
>> >> >> On broken kernels rtsx_usb and rtsx_usb_sdmmc load and the platform
>> >> >> devices rtsx_usb_sdmmc.0.auto / rtsx_usb_ms.1.auto exist, but no
>> >> >> mmc host/card appears (no mmc0, no mmcblk0) and there are no errors
>> >> >> in dmesg. Reloading rtsx_usb / rtsx_usb_sdmmc, re-inserting the card
>> >> >> and disabling USB autosuspend (power/control=on) do not help.
>> >> >>
>> >> >> Since 7.2.x worked but 6.18.x does not, I suspect a change that was
>> >> >> backported to stable.
>> >> >
>> >> > Might, but might not -- and I wonder if you have two bugs, some race,
>> or
>> >> > if some .config setting is disturbing something. Overall this
>> situations
>> >> > is somewhat puzzling. The best way to bring some light into this is
>> >> afaics:
>> >> >
>> >> > Check if 7.2 is working; if it is, bisect between that and 7.3.3; of
>> >> > not, bisect between 7.2 and 7.2.x to find what fixes things. And
>> ensure
>> >> > to use the same .config as a base during the bisection, as explained
>> >> here:
>> >> >
>> >>
>> https://docs.kernel.org/admin-guide/verify-bugs-and-bisect-regressions.html
>> >> >
>> >> > dmesg outputs from a working and a not-that-different version that is
>> >> > broken (say 7.2 and 7.3.3) would be helpful, too.
>> >> >
>> >> > Ciao, Thorsten
>> >>
>> >> I found the culprit:
>> >>
>> >>   7185b6d33b17 ("mmc: rtsx_usb_sdmmc: suppress false CD after init
>> >> timeout")
>> >>
>> >> Reverting just that commit on top of 7.3.4 fixes it. Same kernel
>> >> version and config, the revert being the only difference:
>> >>
>> >>   7.3.4:           card not detected
>> >>   7.3.4 + revert:  card detected again
>> >>
>> >> dmesg with the revert:
>> >>
>> >> [    4.133620] usbcore: registered new interface driver rtsx_usb
>> >> [    5.582812] mmc0: new high speed SD card at address b368
>> >> [    5.638774] mmcblk0: mmc0:b368 SD 1.90 GiB
>> >>
>> >> Without the revert, nothing card related shows up after the
>> >> rtsx_usb line.
>> >>
>> >> Hardware: Lenovo V110-15IKB, internal Realtek RTS5129 (0bda:0129),
>> >> no tray, plain SD slot. The card is permanently inserted and holds
>> >> a LUKS key, so it has to be detected during boot.
>> >>
>> >> Judging from the commit message, I assume an init command times out
>> >> before the card is attached, suppress_cd gets set, and as the card
>> >> is never removed, raw SD_CD never drops and the suppression is never
>> >> cleared. Note that physically removing and re-inserting the card on
>> >> 7.3.3 did not bring it back either, so the clearing path does not
>> >> seem to work here as intended.
>> >>
>> >> Sean, Greg, Ulf: CCing you as author/acker/committer.
>> >> Happy to test patches.
>> >>
>> >> #regzbot introduced: 7185b6d33b17
>> >>
>> >> Philipp
>> >>
>>
>> Hi,
>>
>> Attached is the full dmesg from an unpatched 7.3.4, booted with
>> rtsx_usb_sdmmc.dyndbg=+p rtsx_usb.dyndbg=+p mmc_core.dyndbg=+p
>> The card was inserted the whole time.
>>
>> The relevant part:
>>
>> [    4.273107] mmc0: starting CMD0 arg 00000000 flags 000000c0
>> [    4.274391] mmc0: req done (CMD0): 0: 00000000 00000000 00000000
>> 00000000
>> [    4.277087] mmc0: starting CMD8 arg 000001aa flags 000002f5
>> [    4.909018] rtsx_usb_sdmmc rtsx_usb_sdmmc.0.auto: rtsx_usb_get_rsp
>> failed (err = -110)
>> [    4.909149] mmc0: req done (CMD8): -110: 00000000 00000000 00000000
>> 00000000
>> [    4.909157] mmc0: starting CMD55 arg 00000000 flags 000000f5
>> [    4.909313] rtsx_usb_sdmmc rtsx_usb_sdmmc.0.auto: cmd->error = -123
>>
>> After the CMD8 timeout every further command (CMD55, CMD1, and the
>> retries at 300 and 250 kHz) fails immediately with -ENOMEDIUM. The
>> same pattern repeats at ~82s after runtime resume.
>>
>> The card is a 2 GB standard capacity SD card, so most likely SD 1.x,
>> which per spec does not respond to CMD8 at all. On 7.2 the core then
>> simply continued with CMD55/ACMD41. With 7185b6d33b17 that CMD8
>> timeout is treated as "no media", so I suspect all pre-SD 2.0 cards
>> are affected, not just mine.
>>
>> Philipp
>>

Works for me, the card is detected again on 7.3.4 with your patch
applied (and without the revert):

[    5.647781] mmc0: new high speed SD card at address b368
[    5.693354] mmcblk0: mmc0:b368 SD 1.90 GiB

Tested-by: Philipp Jonas <pjjonas@web.de>

Thanks!
Philipp

      parent reply	other threads:[~2026-11-20 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 18:51 [REGRESSION] rtsx_usb_sdmmc: RTS5129 (0bda:0129) no longer detects SD card Philipp
2026-11-11  9:06 ` Thorsten Leemhuis
2026-11-14 19:25   ` Philipp Jonas
2026-11-14 19:43   ` Philipp Jonas
2026-11-14 20:53   ` Philipp Jonas
     [not found]     ` <CABtds-3f_Gcsd6_vgcbqiAoN-9AUwHg5cr71VetRpO5jC4ZxFw@mail.gmail.com>
2026-11-19 18:33       ` Philipp Jonas
2026-11-20  7:16         ` Sean Rhodes
     [not found]         ` <CABtds-0DNu1HP1M5qf34SWEMoYW3i9jkNxOYg5+7gywGU01nwg@mail.gmail.com>
2026-11-20 14:43           ` Philipp Jonas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DN049N2EXDXT.30B93GJPIZN9S@web.de \
    --to=pjjonas@web.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=sean@starlabs.systems \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox