From: Russell King <rmk+kernel@arm.linux.org.uk>
To: Chris Ball <chris@printf.net>
Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
Markus Mayer <markus.mayer@linaro.org>,
Christian Daudt <csd@broadcom.com>,
Matt Porter <matt.porter@linaro.org>
Subject: [PATCH] mmc: sdhci-bcm-kona: fix build errors when built-in
Date: Wed, 26 Feb 2014 11:42:13 +0000 [thread overview]
Message-ID: <E1WIcsP-0003s2-1q@rmk-PC.arm.linux.org.uk> (raw)
`sdhci_bcm_kona_remove' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o
Fixes: 058feb53666f ("mmc: sdhci-bcm-kona: make linker-section warning go away")
Cc: Markus Mayer <markus.mayer@linaro.org>
Cc: Christian Daudt <csd@broadcom.com>
Cc: Matt Porter <matt.porter@linaro.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
Spotted in nightly build testing, this really should not have happened.
The commit which caused it does more damage than good by changing more
than it should have to fix the warning it reports to have fixed, by
turning it into a build error instead. Please be more careful in
future when making such changes to fully understand what the section
mismatch errors mean and more importantly, exactly what they're referring
to. Thanks.
drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index 20096aaf14b4..e05c39e6292f 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -318,7 +318,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
return ret;
}
-static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
+static int sdhci_bcm_kona_remove(struct platform_device *pdev)
{
return sdhci_pltfm_unregister(pdev);
}
--
1.8.3.1
reply other threads:[~2014-02-26 11:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1WIcsP-0003s2-1q@rmk-PC.arm.linux.org.uk \
--to=rmk+kernel@arm.linux.org.uk \
--cc=chris@printf.net \
--cc=csd@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).