[PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[Jean-Francois Dagenais]

This increases consistency of the code across the sdhci family.

v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.

Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
---
 drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index b13c0a7d50e4..528a5d24c0bc 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
 	u32 vendor;
 	struct sdhci_host *host = mmc_priv(mmc);
 
-	vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
+	vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
 	if (ios->enhanced_strobe)
 		vendor |= VENDOR_ENHANCED_STROBE;
 	else
 		vendor &= ~VENDOR_ENHANCED_STROBE;
 
-	writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
+	sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
 }
 
 static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
-- 
2.11.0

Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[Michal Simek]

On 17.7.2017 03:23, Jean-Francois Dagenais wrote:
> This increases consistency of the code across the sdhci family.
> 
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.

Information about patch version shouldn't be the part of commit message
but they should be placed below ---.

Thanks,
Michal


> 
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
>  	u32 vendor;
>  	struct sdhci_host *host = mmc_priv(mmc);
>  
> -	vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
>  	if (ios->enhanced_strobe)
>  		vendor |= VENDOR_ENHANCED_STROBE;
>  	else
>  		vendor &= ~VENDOR_ENHANCED_STROBE;
>  
> -	writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
>  }
>  
>  static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
> 

Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[Jean-Francois Dagenais]

> On Jul 17, 2017, at 02:33, Michal Simek <michal.simek@xilinx.com> wrote:
> 
> Information about patch version shouldn't be the part of commit message
> but they should be placed below ---.

Sorry, still perfecting this mailing patches art. Wish it was merge requests on
github... less decorum and chances to get it wrong!

I had put the "-v2" switch on "git send-email" but it didn't appear in the
commit msg??

Also, I got a "kbuild test robot" build regression notice, but the contained
errors seem unrelated to my patch... Should I do anything about that?

Should I formulate a v3?

Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[Adrian Hunter]

On 17/07/17 04:23, Jean-Francois Dagenais wrote:
> This increases consistency of the code across the sdhci family.
> 
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.

As mentioned elsewhere, v2 comment doesn't belong in commit message.

> 
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
>  	u32 vendor;
>  	struct sdhci_host *host = mmc_priv(mmc);
>  
> -	vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
>  	if (ios->enhanced_strobe)
>  		vendor |= VENDOR_ENHANCED_STROBE;
>  	else
>  		vendor &= ~VENDOR_ENHANCED_STROBE;
>  
> -	writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
>  }
>  
>  static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
> 

Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[Shawn Lin]

在 2017/7/17 9:23, Jean-Francois Dagenais 写道:
> This increases consistency of the code across the sdhci family.
>
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Apart from the msg above,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

And I included your patch for my other test for sdhci-of-arasan this
afternoon, so

Tested-by: Shawn Lin <shawn.lin@rock-chips.com>



> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
>  	u32 vendor;
>  	struct sdhci_host *host = mmc_priv(mmc);
>
> -	vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
>  	if (ios->enhanced_strobe)
>  		vendor |= VENDOR_ENHANCED_STROBE;
>  	else
>  		vendor &= ~VENDOR_ENHANCED_STROBE;
>
> -	writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
>  }
>
>  static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
>


-- 
Best Regards
Shawn Lin

Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h

[Ulf Hansson]

On 17 July 2017 at 03:23, Jean-Francois Dagenais
<jeff.dagenais@gmail.com> wrote:
> This increases consistency of the code across the sdhci family.
>
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>

Thanks applied for next, by dropping the version history from the change log.

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
>         u32 vendor;
>         struct sdhci_host *host = mmc_priv(mmc);
>
> -       vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +       vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
>         if (ios->enhanced_strobe)
>                 vendor |= VENDOR_ENHANCED_STROBE;
>         else
>                 vendor &= ~VENDOR_ENHANCED_STROBE;
>
> -       writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +       sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
>  }
>
>  static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
> --
> 2.11.0
>