Re: [v2] mmc: sdhci-brcmstb: Remove incorrect capability

[Jaedon Shin <jaedon.shin@gmail.com>]

Hi Ulf,

2016. 8. 29., 오후 8:13, Ulf Hansson <ulf.hansson@linaro.org> 작성:
> 
> On 29 August 2016 at 11:17, Jaedon Shin <jaedon.shin@gmail.com> wrote:
>> Removes incorrect 64-bit ADMA capability on Broadcom MIPS based SoCs.
>> The MIPS based BRCMSTB SDHCI host controllers are using ADMA only, but
>> the several chipsets have a incorrect capability about ADMA 64-bit.
>> 
>> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
>> ---
>> drivers/mmc/host/sdhci-brcmstb.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
>> index cce10fe3e19e..683bfc2af512 100644
>> --- a/drivers/mmc/host/sdhci-brcmstb.c
>> +++ b/drivers/mmc/host/sdhci-brcmstb.c
>> @@ -98,6 +98,8 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
>>         * properties through mmc_of_parse().
>>         */
>>        host->caps = sdhci_readl(host, SDHCI_CAPABILITIES);
>> +       if (IS_ENABLED(CONFIG_MIPS))
> 
> I thought we agreed on using a specific DT compatible string to
> distinguish what to do here was better? No?

My mistake. please drop this patch.

The v3 patch should have new compatible string “brcm,bcm7445-sdhci”. The BCM7445 is
initial and typical 28nm generation ARM SoC. I’ll be send updated patch next day.

Thanks,
Jaedon

> 
>> +               host->caps &= ~SDHCI_CAN_64BIT;
>>        host->caps1 = sdhci_readl(host, SDHCI_CAPABILITIES_1);
>>        host->caps1 &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_SDR104 |
>>                        SDHCI_SUPPORT_DDR50);
>> --
>> 2.9.3
>> 
> 
> Kind regards
> Uffe