From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BF5C63798 for ; Thu, 26 Nov 2020 07:27:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1114A21D7F for ; Thu, 26 Nov 2020 07:27:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S79InGQM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730004AbgKZH11 (ORCPT ); Thu, 26 Nov 2020 02:27:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:42662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727690AbgKZH11 (ORCPT ); Thu, 26 Nov 2020 02:27:27 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C3A421D81; Thu, 26 Nov 2020 07:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606375646; bh=Jhy6nXSwlJkOlHBD5C6ynntz3eKzwcrAp3/DgIorPoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S79InGQMVvFh4rAkwAFhZj7M3WPxwS7zPptn4W+G6tsAN5RBwIUWFuSUSBLt5lCCj rOFlvP2p+A4ZzyPGfFt7uqwadTGggoR4AuCl41i3ols3iz9Dbzg1y1rvdNzynUQCCA X8Fx72750pIXo9IB0pMKWzBe9jL9PDpiP0jaC7wo= Date: Thu, 26 Nov 2020 08:28:31 +0100 From: Greg Kroah-Hartman To: Arend Van Spriel Cc: Brian O'Keefe , Ulf Hansson , linux-mmc@vger.kernel.org, linux-wireless@vger.kernel.org, Hans de Goede , Larry Finger Subject: Re: [PATCH 1/2] mmc: sdio: Move SDIO IDs from rtl8723bs, driver to common include file Message-ID: References: <16529bfd-0308-5da9-f7ce-4ffa9f77b4d0@alum.wpi.edu> <1760357a038.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1760357a038.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, Nov 26, 2020 at 07:57:23AM +0100, Arend Van Spriel wrote: > On November 25, 2020 8:13:07 PM Greg Kroah-Hartman > wrote: > > > On Wed, Nov 25, 2020 at 01:33:00PM -0500, Brian O'Keefe wrote: > > > Macro names were derived from the Windows driver, as that was the best > > > available source. > > > > Why move these? What does this help with? > > Hi Greg, > > Most if not all SDIO-based (wifi) drivers in mainline have their venid and > devid definitions in that header file. So seems like a good idea to me, but > maybe not so for a staging driver? If the driver ever gets moved out, maybe do it then as part of that effort. I haven't seen that happening, so I would recommend just leaving this alone for now. thanks, greg k-h