From: Greg KH <greg@kroah.com>
To: "Christian Löhle" <CLoehle@hyperstone.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: block: Remove error check of hw_reset on reset
Date: Mon, 31 Oct 2022 10:53:58 +0100 [thread overview]
Message-ID: <Y1+bNsOJK7kB0yBZ@kroah.com> (raw)
In-Reply-To: <0b965373ab0a4d35b0d98071a71fc304@hyperstone.com>
On Mon, Oct 31, 2022 at 09:39:53AM +0000, Christian Löhle wrote:
> commit 406e14808ee6 upstream
>
> Before switching back to the right partition in mmc_blk_reset there used
> to be a check if hw_reset was even supported. This return value
> was removed, so there is no reason to check. Furthermore ensure
> part_curr is not falsely set to a valid value on reset or
> partition switch error.
>
> As part of this change the code paths of mmc_blk_reset calls were checked
> to ensure no commands are issued after a failed mmc_blk_reset directly
> without going through the block layer.
>
> Fixes: fefdd3c91e0a ("mmc: core: Drop superfluous validations in mmc_hw|sw_reset()")
>
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
> drivers/mmc/core/block.c | 44 ++++++++++++++++++++++++----------------
> 1 file changed, 26 insertions(+), 18 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-10-31 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 9:39 [PATCH] mmc: block: Remove error check of hw_reset on reset Christian Löhle
2022-10-31 9:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1+bNsOJK7kB0yBZ@kroah.com \
--to=greg@kroah.com \
--cc=CLoehle@hyperstone.com \
--cc=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox