From: Eric Biggers <ebiggers@kernel.org>
To: Peng Zhou <peng.zhou@mediatek.com>
Cc: linux-mmc@vger.kernel.org,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Satya Tangirala <satyat@google.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Wulin Li <wulin.li@mediatek.com>,
Stanley Chu <stanley.chu@mediatek.com>
Subject: Re: [PATCH v2 2/2] mmc: mediatek: enable crypto hardware engine
Date: Tue, 9 Feb 2021 23:44:59 -0800 [thread overview]
Message-ID: <YCOO+xHC4JZoD1rX@sol.localdomain> (raw)
In-Reply-To: <20210129071107.9129-1-peng.zhou@mediatek.com>
On Fri, Jan 29, 2021 at 03:11:07PM +0800, Peng Zhou wrote:
> @@ -2770,6 +2781,15 @@ static int __maybe_unused msdc_runtime_resume(struct device *dev)
>
> msdc_ungate_clock(host);
> msdc_restore_reg(host);
> +
> + /*
> + * 1: MSDC_AES_CTL_INIT
> + * 4: cap_id, no-meaning now
> + * 1: cfg_id, we choose the second cfg group
> + */
> + if (mmc->caps2 & MMC_CAP2_CRYPTO)
> + arm_smccc_smc(MTK_SIP_MMC_CONTROL,
> + 1, 4, 1, 0, 0, 0, 0, &smccc_res);
> return 0;
> }
>
This part doesn't compile because there is no smccc_res variable. It worked if
I added it as a local variable in this function.
- Eric
prev parent reply other threads:[~2021-02-10 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 7:11 [PATCH v2 2/2] mmc: mediatek: enable crypto hardware engine Peng Zhou
2021-02-10 7:44 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCOO+xHC4JZoD1rX@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=linux-mmc@vger.kernel.org \
--cc=peng.zhou@mediatek.com \
--cc=satyat@google.com \
--cc=stanley.chu@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=wulin.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox