From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org,
Aniruddha Tvs Rao <anrao@nvidia.com>,
Kamal Mostafa <kamal@canonical.com>
Subject: Re: [PATCH] mmc: sdhci-tegra: Add required callbacks to set/clear CQE_EN bit
Date: Wed, 7 Apr 2021 17:07:44 +0200 [thread overview]
Message-ID: <YG3KwJdljfJdawDQ@orome.fritz.box> (raw)
In-Reply-To: <20210407094617.770495-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Wed, Apr 07, 2021 at 10:46:17AM +0100, Jon Hunter wrote:
> From: Aniruddha Tvs Rao <anrao@nvidia.com>
>
> CMD8 is not supported with Command Queue Enabled. Add required callback
> to clear CQE_EN and CQE_INTR fields in the host controller register
> before sending CMD8. Add corresponding callback in the CQHCI resume path
> to re-enable CQE_EN and CQE_INTR fields.
>
> Reported-by: Kamal Mostafa <kamal@canonical.com>
> Tested-by: Kamal Mostafa <kamal@canonical.com>
> Signed-off-by: Aniruddha Tvs Rao <anrao@nvidia.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/mmc/host/sdhci-tegra.c | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-07 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:46 [PATCH] mmc: sdhci-tegra: Add required callbacks to set/clear CQE_EN bit Jon Hunter
2021-04-07 11:03 ` Adrian Hunter
2021-04-07 15:07 ` Thierry Reding [this message]
2021-04-12 7:52 ` Ulf Hansson
2021-04-12 9:35 ` Jon Hunter
2021-04-12 11:51 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG3KwJdljfJdawDQ@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=anrao@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kamal@canonical.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox