Re: [PATCH/RFC v2] mmc: host: renesas_sdhi: Refactor of_device_id.data

Wolfram Sang
2021-06-30T07:34:44Z

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Hi Shimoda-san,

> > I think this Rep-by can go. Test bot mentioned one build error of v1,
> > but it didn't report that we should refactor this code.
>
> You're correct. Perhaps, adding "# build fix on RFC" is better?
> I checked the commit history, and I found such tags.

Oh, I didn't know that way. It sounds good!

> > You leave the quirk handling of different ES versions still in
> > renesas_sdhi_core. I'd think this should also be moved to
> > renesas_sdhi_internal_dmac? Then we have all the handling in one place.
>
> I think so. So, I'll try this.

Glad you like it :)

Happy hacking,

Wolfram