From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH v3 3/3] mmc: renesas_sdhi: do hard reset if possible
Date: Thu, 26 Aug 2021 10:16:45 +0200 [thread overview]
Message-ID: <YSdN7YWXwC0HvE3L@shikoro> (raw)
In-Reply-To: <CAMuHMdU6=rTHjvcgK8GBzd3OL_9YFqV77=KsAEGJvAVapnhsOQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Wed, Apr 28, 2021 at 04:36:17PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Wed, Mar 17, 2021 at 10:17 AM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > All recent SDHI instances can be reset via the reset controller. If one
> > is found, use it instead of the open coded reset. This is to get a
> > future-proof sane reset state.
> >
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Thanks for your patch, which is now commit b4d86f37eacb7246 ("mmc:
> renesas_sdhi: do hard reset if possible") in mmc/next.
>
> This breaks SDHI on koelsch (R-Car M2-W).
> In v5.10, v5.11, and v512, it works fine:
I think I have a fix and will send it out in some minutes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-08-26 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:16 [PATCH v3 0/3] mmc: renesas_sdhi: reset via reset controller Wolfram Sang
2021-03-17 9:16 ` [PATCH v3 1/3] mmc: tmio: abort DMA before reset Wolfram Sang
2021-03-17 9:16 ` [PATCH v3 2/3] mmc: renesas_sdhi: break SCC reset into own function Wolfram Sang
2021-03-17 9:16 ` [PATCH v3 3/3] mmc: renesas_sdhi: do hard reset if possible Wolfram Sang
2021-04-28 14:36 ` Geert Uytterhoeven
2021-06-18 9:36 ` Wolfram Sang
2021-06-18 9:42 ` Geert Uytterhoeven
2021-06-18 9:57 ` Wolfram Sang
2021-06-18 10:53 ` Geert Uytterhoeven
2021-08-26 8:16 ` Wolfram Sang [this message]
2021-03-19 14:12 ` [PATCH v3 0/3] mmc: renesas_sdhi: reset via reset controller Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSdN7YWXwC0HvE3L@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox