Re: [PATCH 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

Randy Dunlap
2021-10-30T00:00:49Z

On 10/28/21 10:57 PM, LH.Kuo wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 95b3511..6f8bcd6 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -14,6 +14,16 @@ config MMC_DEBUG
> added host drivers please don't invent their private macro for
> debugging.
>
> +config SP_SDV2
> + tristate "Sunplus SP7021 SD/SDIO Controller"
> + depends on SOC_SP7021
> + default m
> + help
> + This selects the Sunplus SP7021 SD/SDIO controller.
> + If you have a controller with this interface, say Y or M here..
> +
> + If unsure, say N.

Hi,
Does SOC_SP7021 require this driver to be built in order
to boot?
If not, please remove the "default m" line.

Also, several of your patches seem to have lots of line
changes to the MAINTAINERS file, but it looks like they
should not be part of your patch submission.

thanks.
--
~Randy