Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

Randy Dunlap
2021-11-10T02:33:28Z

Hi--

On 11/8/21 11:58 PM, LH.Kuo wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 5af8494..2aba9eb 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1091,5 +1091,15 @@ config MMC_OWL
> This selects support for the SD/MMC Host Controller on
> Actions Semi Owl SoCs.
>
> +config MMC_SP_SDV2
> + tristate "Sunplus SP7021 SD/SDIO Controller"
> + depends on SOC_SP7021
> + help
> + If you say yes here, you will get support for SD/SDIO host interface
> + on sunplus Socs.

Sunplus SoCs.

> + If you have a controller with this interface, say Y or M here.
> + If unsure, say N.

All 4 lines of help text should be indented only with one tab + 2 spaces,
not 2 tabs, per coding-style.rst.

> + Sunplus SD/SDIO Host Controller support"

I am thinking that this last line should not be here at all... ???

thanks.
--
~Randy