Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

Randy Dunlap
2021-11-10T05:44:38Z

Hi--

On 11/9/21 9:40 PM, Lh Kuo 郭力豪 wrote:
> Hi
>
>> -----Original Message-----
>> From: Randy Dunlap <rdunlap@infradead.org>
>> Sent: Wednesday, November 10, 2021 10:33 AM
>> To: LH.Kuo <lhjeff911@gmail.com>; p.zabel@pengutronix.de;
>> daniel.thompson@linaro.org; lee.jones@linaro.org;
>> u.kleine-koenig@pengutronix.de; ulf.hansson@linaro.org; robh+dt@kernel.org;
>> linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org;
>> devicetree@vger.kernel.org
>> Cc: qinjian@cqplus1.com; Wells Lu 呂芳騰 <wells.lu@sunplus.com>; Lh Kuo
>> 郭力豪 <lh.Kuo@sunplus.com>
>> Subject: Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021
>>
>> Hi--
>>
>> On 11/8/21 11:58 PM, LH.Kuo wrote:
>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index 5af8494..2aba9eb 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -1091,5 +1091,15 @@ config MMC_OWL
>>> This selects support for the SD/MMC Host Controller on
>>> Actions Semi Owl SoCs.
>>>
>>> +config MMC_SP_SDV2
>>> + tristate "Sunplus SP7021 SD/SDIO Controller"
>>> + depends on SOC_SP7021
>>> + help
>>> + If you say yes here, you will get support for SD/SDIO host interface
>>> + on sunplus Socs.
>>
>> Sunplus SoCs.
>>
>>> + If you have a controller with this interface, say Y or M here.
>>> + If unsure, say N.
>>
>> All 4 lines of help text should be indented only with one tab + 2 spaces,
>> not 2 tabs, per coding-style.rst.
>>
>>
>>> + Sunplus SD/SDIO Host Controller support"
>>
>> I am thinking that this last line should not be here at all... ???
>>
>>
>> thanks.
>> --
>> ~Randy
>
>
> I will make change as below is it OK ?
>
> config MMC_SP_SDV2
> tristate "Sunplus SP7021 SD/SDIO Controller"
> depends on SOC_SP7021
> help
> This selects the Sunplus Host Controller Interface
> support present in Sunplus SP7021 SOCs. The controller supports
> SD/SDIO devices.
>
> If you have a controller with this interface, say Y or M here.
>
> If unsure, say N.

Too much indentation on the last 2 (non-blank) help text lines.
Should just be one tab + 2 spaces, not 2 tabs.

--
~Randy