Re: [PATCH v2 2/2] devicetree bindings mmc Add bindings doc for Sunplus SP7021

Rob Herring
2021-11-29T01:39:39Z

On Tue, Nov 09, 2021 at 03:58:25PM +0800, LH.Kuo wrote:
> Add devicetree bindings mmc Add bindings doc for Sunplus SP7021
>
> Signed-off-by: LH.Kuo <lh.kuo@sunplus.com>
> ---
> Changes in v2:
> - Addressed all comments from Mr. Philipp Zabel
> - Modified the structure and register access method.
> - Modifiedthe path about MAINTAINERS. ( wrong messages PATH in v1).
>
> .../devicetree/bindings/mmc/sunplus-sd2.yaml | 82 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 83 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml b/Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
> new file mode 100644
> index 0000000..95dc0bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sunplus-sd2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SD/SDIO controller
> +
> +maintainers:
> + - lh.kuo <lh.kuo@sunplus.com>
> +
> +properties:
> + compatible:
> + enum:
> + - sunplus,sp7021-card1
> + - sunplus,sp7021-sdio

What's the difference between these 2 blocks?

> +
> + reg:
> + items:
> + - description: Base address and length of the SD/SDIO registers

Just 'maxItems: 1' is sufficient.

> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + pinctrl-names:
> + description:
> + A pinctrl state named "default" must be defined.
> + const: default
> +
> + pinctrl-0:
> + description:
> + A phandle to the default pinctrl state.
> +
> + max-frequency: true
> +
> +allOf:
> + - $ref: "mmc-controller.yaml"
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> + - pinctrl-names
> + - pinctrl-0
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/sp-sp7021.h>
> + #include <dt-bindings/reset/sp-sp7021.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + mmc1: mmc@9C003e80 {

Use lower case hex.

> + compatible = "sunplus,sp7021-card1";
> + reg = <0x9c003e80 0x280>;
> + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clkc CARD_CTL1>;
> + resets = <&rstc RST_CARD_CTL1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc1_mux &mmc1_mux_cd>;
> + max-frequency = <52000000>;
> + };
> + sdio: mmc@9C008400 {

Use lower case hex.

> + compatible = "sunplus,sp7021-sdio";
> + reg = <0x9c008400 0x280>;
> + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clkc CARD_CTL1>;
> + resets = <&rstc RST_CARD_CTL1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pins_sdio>;
> + max-frequency = <52000000>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2746084..e653a1d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18193,6 +18193,7 @@ SUNPLUS SD/SDIO HOST CONTROLLER INTERFACE DRIVER
> M: LH Kuo <lh.kuo@sunplus.com>
> L: linux-mmc@vger.kernel.org
> S: Maintained
> +F: Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
> F: drivers/mmc/host/sunplus_sd2.*
>
> SUPERH
> --
> 2.7.4
>
>