From: Rob Herring <robh@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <treding@nvidia.com>,
~okias/devicetree@lists.sr.ht, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names
Date: Tue, 4 Jan 2022 12:53:25 -0600 [thread overview]
Message-ID: <YdSXpXI72sjrULVM@robh.at.kernel.org> (raw)
In-Reply-To: <20211224192545.74528-1-david@ixit.cz>
On Fri, Dec 24, 2021 at 08:25:45PM +0100, David Heidelberg wrote:
> We don't care in which order are "rx" and "tx" DMA names supplied.
>
I do. Other than avoiding dts changes, why do we need undefined order
here?
> Fixes: 4df297aaeb9c ("dt-bindings: mmc: Add missing properties used in examples")
>
Drop the blank line.
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> index f0a44b2cfa79..a4f74bec68a3 100644
> --- a/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arm,pl18x.yaml
> @@ -70,9 +70,13 @@ properties:
> maxItems: 2
>
> dma-names:
> - items:
> - - const: rx
> - - const: tx
> + oneOf:
> + - items:
> + - const: tx
> + - const: rx
> + - items:
> + - const: rx
> + - const: tx
For future reference, the concise way to express this is:
maxItems: 2
items:
enum: [ rx, tx ]
>
> power-domains: true
>
> --
> 2.34.1
>
>
prev parent reply other threads:[~2022-01-04 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 19:25 [PATCH] dt-bindings: mmc: PL18x stop relying on order of dma-names David Heidelberg
2021-12-26 3:31 ` Linus Walleij
2021-12-28 16:58 ` Ulf Hansson
2022-01-04 18:53 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdSXpXI72sjrULVM@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox