From: Petr Vorel <petr.vorel@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konradybcio@gmail.com>,
Jean Thomas <virgule@jeanthomas.me>,
Alexey Minnekhanov <alexeymin@postmarketos.org>,
Andy Gross <agross@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Taniya Das <tdas@codeaurora.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: qcom: msm8994-huawei-angler: Add sdhc{1,2} definitions
Date: Mon, 31 Jan 2022 23:46:54 +0100 [thread overview]
Message-ID: <Yfhm3opZCtAxMwrY@pevik> (raw)
In-Reply-To: <YfhmF6FKV9/6YfAL@builder.lan>
Hi Bjorn,
> On Thu 13 Jan 17:33 CST 2022, Petr Vorel wrote:
> > Although downstream supports HS400, there are overclocking warnings when
> > using mmc-hs400-1_8v:
> > mmc0: Card appears overclocked; req 200000000 Hz, actual 384000000 Hz
> > mmc0: Card appears overclocked; req 200000000 Hz, actual 384000000 Hz
> > mmc0: Card appears overclocked; req 200000000 Hz, actual 384000000 Hz
> > mmc0: Card appears overclocked; req 400000000 Hz, actual 768000000 Hz
> > mmc0: Card appears overclocked; req 400000000 Hz, actual 768000000 Hz
> > mmc0: new HS400 MMC card at address 0001
> > Using HS200 (i.e. mmc-hs200-1_8v or mmc-ddr-1_8v) would reduce them:
> > mmc0: Card appears overclocked; req 200000000 Hz, actual 384000000 Hz
> > mmc0: Card appears overclocked; req 200000000 Hz, actual 384000000 Hz
> > mmc0: new HS200 MMC card at address 0001
> > But as the problem is probably elsewhere (bullhead behaves the same),
> > keep mmc-hs400-1_8v.
> > Angler does not have SD card, thus explicitly disable sdhc2.
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > .../dts/qcom/msm8994-huawei-angler-rev-101.dts | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> > diff --git a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
> > index 0e3dd48f0dbf..5ce3dc169bb4 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
> > +++ b/arch/arm64/boot/dts/qcom/msm8994-huawei-angler-rev-101.dts
> > @@ -7,6 +7,7 @@
> > /dts-v1/;
> > #include "msm8994.dtsi"
> > +#include <dt-bindings/gpio/gpio.h>
> > /* Angler's firmware does not report where the memory is allocated */
> > /delete-node/ &cont_splash_mem;
> > @@ -41,3 +42,18 @@ serial@f991e000 {
> > &tlmm {
> > gpio-reserved-ranges = <85 4>;
> > };
> > +
> > +/*
> > + * Although downstream supports also HS400 there are fewer overclocking
> > + * warnings when used DDR, also LK bootloader reports DDR mode.
> > + */
> > +&sdhc1 {
> > + status = "okay";
> > +
> > + mmc-hs400-1_8v;
> > +};
> > +
> > +/* Angler does not have SD card */
> > +&sdhc2 {
> But isn't &sdhc2 already disabled from msm8992.dtsi and msm8994.dtsi?
Yes it's disabled, thus this is not needed.
I'll send v2 of this, where I remove this.
Kind regards,
Petr
> Regards,
> Bjorn
next prev parent reply other threads:[~2022-01-31 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 23:33 [PATCH 0/6] msm8994-huawei-angler and msm8992-lg-bullhead sdhc1 fixes Petr Vorel
2022-01-13 23:33 ` [PATCH 1/6] arm64: dts: qcom: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file Petr Vorel
2022-01-13 23:33 ` [PATCH 2/6] arm64: dts: qcom: msm8992-lg-bullhead: Add support for LG Bullhead rev 1.0 Petr Vorel
2022-01-13 23:33 ` [PATCH 3/6] arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC Petr Vorel
2022-01-13 23:33 ` [PATCH 4/6] arm64: dts: qcom: msm8994-huawei-angler: Add vendor name huawei Petr Vorel
2022-01-13 23:33 ` [PATCH 5/6] arm64: dts: qcom: msm8994-huawei-angler: Add sdhc{1,2} definitions Petr Vorel
2022-01-13 23:40 ` Petr Vorel
2022-01-14 18:27 ` Konrad Dybcio
2022-01-14 21:16 ` Petr Vorel
2022-01-14 21:19 ` Konrad Dybcio
2022-01-31 22:43 ` Bjorn Andersson
2022-01-31 22:46 ` Petr Vorel [this message]
2022-01-13 23:33 ` [PATCH 6/6] arm64: dts: qcom: msm8992-lg-bullhead: Disable sdhc2 Petr Vorel
2022-02-01 5:19 ` (subset) [PATCH 0/6] msm8994-huawei-angler and msm8992-lg-bullhead sdhc1 fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfhm3opZCtAxMwrY@pevik \
--to=petr.vorel@gmail.com \
--cc=agross@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tdas@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=virgule@jeanthomas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).