From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] mmc: renesas_sdhi: Add missing checks for the presence of quirks
Date: Fri, 1 Apr 2022 18:01:03 +0200 [thread overview]
Message-ID: <Ykchv+A4jijyOtbT@ninjato> (raw)
In-Reply-To: <cc3178c2ff60f640f4d5a071d51f6b0b1db37656.1648822020.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Fri, Apr 01, 2022 at 04:09:28PM +0200, Geert Uytterhoeven wrote:
> When running on an system without any quirks (e.g. R-Car V3U), the
> kernel crashes with a NULL pointer dereference:
>
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000002
> ...
> Hardware name: Renesas Falcon CPU and Breakout boards based on r8a779a0 (DT)
> Workqueue: events_freezable mmc_rescan
> ...
> Call trace:
> renesas_sdhi_internal_dmac_start_dma+0x54/0x12c
> tmio_process_mrq+0x124/0x274
>
> Fix this by adding the missing checks for the validatity of the
> priv->quirks pointer.
>
> Fixes: dce2ba8b2ee8cef6 ("mmc: renesas_sdhi: make 'dmac_only_one_rx' a quirk")
> Fixes: d4bfa17a655c6de2 ("mmc: renesas_sdhi: make 'fixed_addr_mode' a quirk")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks for catching this!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-01 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:09 [PATCH] mmc: renesas_sdhi: Add missing checks for the presence of quirks Geert Uytterhoeven
2022-04-01 16:01 ` Wolfram Sang [this message]
2022-04-04 11:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykchv+A4jijyOtbT@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert+renesas@glider.be \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox