Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH] mmc: renesas_sdhi: special 4tap settings only apply to HS400
Date: Mon, 4 Apr 2022 14:16:09 +0200	[thread overview]
Message-ID: <YkrhiUdx+BeWOoHA@ninjato> (raw)
In-Reply-To: <CAMuHMdVJ7r1RXgoHAP1+RLtm11XMFzs1zht7+KQnUss=Rx4sBg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]


> >                 bool use_4tap = priv->quirks && priv->quirks->hs400_4taps;
> > -               bool need_slow_clkh = (host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) ||
> > -                                     (host->mmc->ios.timing == MMC_TIMING_MMC_HS400);
> > +               bool need_slow_clkh = host->mmc->ios.timing == MMC_TIMING_MMC_HS400;
> 
> I'm wondering if we've lost the critical mass for keeping the bools?

Might be. I'll think about it.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-04-04 12:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 12:45 [PATCH] mmc: renesas_sdhi: special 4tap settings only apply to HS400 Wolfram Sang
2022-04-04  7:09 ` Yoshihiro Shimoda
2022-04-04 10:05   ` Wolfram Sang
2022-04-04 12:14 ` Geert Uytterhoeven
2022-04-04 12:16   ` Wolfram Sang [this message]
2022-04-06 20:14   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkrhiUdx+BeWOoHA@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox