From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5476C433FE for ; Sat, 1 Oct 2022 06:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229458AbiJAGmU (ORCPT ); Sat, 1 Oct 2022 02:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiJAGmS (ORCPT ); Sat, 1 Oct 2022 02:42:18 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B42186026 for ; Fri, 30 Sep 2022 23:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=/89nnS4Ca4Z9ELgqt6mLiZHkrrWq x7Z0teg6BVDd2Dg=; b=JvPC392QlBSi6u+Y/oDGSjAp0tE5XEU0r6v12zPZfH1T Lw5USGODj87CWvU2H+4/L3xLOVNF2mRQayOJ1QQJdrTSEEe2GYfRs3CRkhZAjHok a1jK2pXEAAPgFx4pkFqnX7liGlJParavvDX2ipUge7P55m+zBnrZ6i1oaA6p/Ks= Received: (qmail 858644 invoked from network); 1 Oct 2022 08:42:12 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 1 Oct 2022 08:42:12 +0200 X-UD-Smtp-Session: l3s3148p1@C2QGafPp18kucrO7 Date: Sat, 1 Oct 2022 08:42:11 +0200 From: Wolfram Sang To: Geert Uytterhoeven Cc: Biju Das , Ulf Hansson , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad Subject: Re: [PATCH v5] mmc: renesas_sdhi: Fix rounding errors Message-ID: Mail-Followup-To: Wolfram Sang , Geert Uytterhoeven , Biju Das , Ulf Hansson , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20220928110755.849275-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LhyXKQm22sMbRxbp" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org --LhyXKQm22sMbRxbp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 30, 2022 at 11:09:07AM +0200, Geert Uytterhoeven wrote: > On Wed, Sep 28, 2022 at 1:08 PM Biju Das wro= te: > > Due to clk rounding errors on RZ/G2L platforms, it selects a clock sour= ce > > with a lower clock rate compared to a higher one. > > For eg: The rounding error (533333333 Hz / 4 * 4 =3D 533333332 Hz < 533= 3333 > > 33 Hz) selects a clk source of 400 MHz instead of 533.333333 MHz. > > > > This patch fixes this issue by adding a margin of (1/1024) higher to > > the clock rate. > > > > Signed-off-by: Biju Das > > --- > > v4->v5: > > * Moved upper limit calculation inside the for loop as it caused > > regression on R-Car M2-W board. > > * Removed Rb tag from Wolfram as there is some new changes. >=20 > Reviewed-by: Geert Uytterhoeven >=20 > Still works fine on R-Car Gen2/Gen3, so: > Tested-by: Geert Uytterhoeven I'll test this patch on Monday. --LhyXKQm22sMbRxbp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmM34UAACgkQFA3kzBSg KbbDsRAAmvX22ffiiTnFr1/d7ZhmEeffxj5M63kbRDb8RkkURGBAWkAkQaJG9blt rKu0ueXSKCrxjVQu2ezMtFTednwwwXAMEIbjwkHEpnNLub3ZJcNzzfQaTfFGavI7 4u1xdUHUPM4+t4KaSHCRHOqUMxF3Aieru2EHfMY6yCyaFnuecb9lfXxmz9dmjqbt 0+74tTdJLZPiTDfA0BL1m3+njPfgNyB5gNfe0295cYOaxNuG3z7wVf4s+QQVhkPo oxIoDNwRc7zjSPKQDwo56FhwXIZVj9lYtPWjLGt7NQUC5tHXsQD0t2oHPXIgaS6I UT8dICrcXWe2DyYHi8H/QI+NzhhB96Ozl0jelMAWXKwKDDDzc3yKDi8NVZG0u6Ki C4h91v3+xHJDECv2q8kQpRBf4Dav3d9qQu1haGeEWpjQiQP38fJgrZEyxvlapfZ7 RJ5tpQy7AO/Rhr3eNod+CG3e2guaBtDspSiYN62hROJLTVDXcME35L1TUzDRAr6C 9SVq+AUh+BrSQaE7nnpdQE7Z3Lo6AY7JNacAOlYvZCmBImau6Epi6Q2FSCanMicC 9cruWLYLw5RLLkKqrgV/2HKVJ8qyUMQ1bRZPoWwEtvAqoolfRsyXeo8eQWo97wXt ODby7q6Cp5d7MVwarylbEWjTEs6QZIJvNGQoLeMwFkrd54+/B9o= =h/pB -----END PGP SIGNATURE----- --LhyXKQm22sMbRxbp--