From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v3 3/8] mmc: renesas_sdhi: Add support for RZ/G3E SoC
Date: Fri, 28 Feb 2025 10:42:00 +0100 [thread overview]
Message-ID: <Z8GE6G4TXC7dOB6_@shikoro> (raw)
In-Reply-To: <20250206134047.67866-4-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On Thu, Feb 06, 2025 at 01:40:27PM +0000, Biju Das wrote:
> The SDHI/eMMC IPs in the RZ/G3E SoC are similar to those in R-Car Gen3.
> However, the RZ/G3E SD0 channel has Voltage level control and PWEN pin
> support via SD_STATUS register.
>
> internal regulator support is added to control the voltage levels of
> the SD pins via sd_iovs/sd_pwen bits in SD_STATUS register by populating
> vqmmc-regulator child node.
>
> SD1 and SD2 channels have gpio regulator support and internal regulator
> support. Selection of the regulator is based on the regulator phandle.
> Similar case for SD0 fixed voltage (eMMC) that uses fixed regulator and
> SD0 non-fixed voltage (SD0) that uses internal regulator.
Okay, since I don't see a constant state of the regulator, let's just
restore the original value as you do here. I mean it works.
> + if (priv->rdev)
> + sd_ctrl_read32_rep(host, CTL_SD_STATUS, &sd_status, 1);
What about introducing sd_ctrl_read32? Or ask the engineers to move
SD_STATUS_IOVS to bit 15 ;)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-02-28 9:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 13:40 [PATCH v3 0/8] Add RZ/G3E SDHI support Biju Das
2025-02-06 13:40 ` [PATCH v3 1/8] dt-bindings: mmc: renesas,sdhi: Document RZ/G3E support Biju Das
2025-02-06 13:40 ` [PATCH v3 2/8] mmc: renesas_sdhi: Arrange local variables in reverse xmas tree order Biju Das
2025-02-28 9:36 ` Wolfram Sang
2025-02-28 10:51 ` Biju Das
2025-02-06 13:40 ` [PATCH v3 3/8] mmc: renesas_sdhi: Add support for RZ/G3E SoC Biju Das
2025-02-27 15:16 ` Wolfram Sang
2025-02-27 15:29 ` Biju Das
2025-02-27 16:27 ` Biju Das
2025-02-27 19:02 ` Biju Das
2025-02-28 7:23 ` Biju Das
2025-02-28 9:15 ` Wolfram Sang
2025-02-28 9:42 ` Wolfram Sang [this message]
2025-02-28 10:50 ` Biju Das
2025-02-20 7:11 ` [PATCH v3 0/8] Add RZ/G3E SDHI support Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8GE6G4TXC7dOB6_@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox