From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v4 2/2] mmc: renesas_sdhi: Add support for RZ/G3E SoC
Date: Fri, 28 Feb 2025 22:24:34 +0100 [thread overview]
Message-ID: <Z8Ipkqod7SdGlDak@shikoro> (raw)
In-Reply-To: <20250228124713.153979-3-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
> +static struct regulator_desc renesas_sdhi_vqmmc_regulator = {
> + .of_match = of_match_ptr("vqmmc-regulator"),
> + .owner = THIS_MODULE,
> + .type = REGULATOR_VOLTAGE,
> + .ops = &renesas_sdhi_regulator_voltage_ops,
> + .volt_table = renesas_sdhi_vqmmc_voltages,
> + .n_voltages = ARRAY_SIZE(renesas_sdhi_vqmmc_voltages),
> +};
...
> + renesas_sdhi_vqmmc_regulator.name = "sdhi-vqmmc-regulator";
> + renesas_sdhi_vqmmc_regulator.of_match = of_match_ptr("vqmmc-regulator");
> + renesas_sdhi_vqmmc_regulator.type = REGULATOR_VOLTAGE;
> + renesas_sdhi_vqmmc_regulator.owner = THIS_MODULE;
?
Also, one space only before '=' in the struct initializer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-02-28 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 12:47 [PATCH v4 0/2] Add RZ/G3E SDHI support Biju Das
2025-02-28 12:47 ` [PATCH v4 1/2] dt-bindings: mmc: renesas,sdhi: Document RZ/G3E support Biju Das
2025-02-28 21:32 ` Wolfram Sang
2025-02-28 12:47 ` [PATCH v4 2/2] mmc: renesas_sdhi: Add support for RZ/G3E SoC Biju Das
2025-02-28 21:24 ` Wolfram Sang [this message]
2025-03-03 11:24 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8Ipkqod7SdGlDak@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox