Re: [PATCH v5 2/6] dt-bindings: ufs: qcom: Add ICE phandle

Abel Vesa
2023-04-04T08:59:18Z

On 23-04-04 07:41:55, Krzysztof Kozlowski wrote:
> On 03/04/2023 22:05, Abel Vesa wrote:
> > Starting with SM8550, the ICE will have its own devicetree node
> > so add the qcom,ice property to reference it.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >
> > The v4 is here:
> > https://lore.kernel.org/all/20230327134734.3256974-4-abel.vesa@linaro.org/
> >
> > Changes since v4:
> > * Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce
> > it while making sure none of the other platforms are allowed to use it
>
> Why?

SM8550 will be the first platform to use the new DT bindings w.r.t ICE.

>
> Also, this does not solve my previous question still.

Well, the clocks are not added for the a few platforms (which include
SM8550). Same for 'ice' reg range.. So the only thing left is to
enforce the qcom,ice property availability only for SM8550. I believe
it solves the mutual exclusiveness of the "ice" reg range along with the
clocks versus the qcom,ice property, by enforcing at compatible level.

Is this not enough?

>
> Best regards,
> Krzysztof
>