From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D910C001DB for ; Fri, 11 Aug 2023 13:42:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbjHKNmt (ORCPT ); Fri, 11 Aug 2023 09:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbjHKNms (ORCPT ); Fri, 11 Aug 2023 09:42:48 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F5F1ED; Fri, 11 Aug 2023 06:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691761368; x=1723297368; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3qCbXJc2LqA6wB4P5vKT0CVjgaPzi1I6Wyv4XAX2IK0=; b=grZy0lwnLMJL5PLZUMBd6w4or7JvD7gE2kgf1yLhx2D0UaBcQ7NkZYwZ XZYggAVT8Hq9B+sJUXt54NAnkE9pcayMr/ROSZzwigOq2TXoUAVAsKj9t UYPP0zi2XqOc4pa4f/UvJZHl5clEGvADc/QEJifA53psvDdceYopN6ZSW 5vR53q9yxWNgLdkBICJ4kLdvuSyKLfrgDc/Xhygz4L/Aq/wGrzltC4e/P uMbiwynFnzkHYpLMQbaMVP4LvsybQIUGripSTMhg9ErqxrNrg65yqOd2g nmetYujmMp4vLguoAWU3SbNZVce9SXjxUiEndy3RTijrmY8RMHPMbEKdi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="371682698" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="371682698" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 06:42:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="802669536" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="802669536" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 11 Aug 2023 06:42:39 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qUSPT-00HEuE-0U; Fri, 11 Aug 2023 16:42:35 +0300 Date: Fri, 11 Aug 2023 16:42:34 +0300 From: Andy Shevchenko To: Adrian Hunter Cc: Ulf Hansson , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Yangtao Li , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Kamal Dasu , Al Cooper , Michal Simek , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Patrice Chotard , Brian Norris , Ye Xingchen , Brad Larson , Christophe JAILLET , Sai Krishna Potthuri , Swati Agarwal , Andy Tang , Georgii Kruglov , Jiapeng Chong , Doug Brown , Li Zetao , Kunihiko Hayashi , Jassi Brar , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/16] mmc: sdhci-pltfm: Minor clean up Message-ID: References: <20230811130351.7038-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811130351.7038-1-adrian.hunter@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Fri, Aug 11, 2023 at 04:03:35PM +0300, Adrian Hunter wrote: > Hi > > sdhci_pltfm_unregister() does: > > clk_disable_unprepare(pltfm_host->clk) > > which prevents drivers from using devm_clk_get_enabled() or similar. > > Move it out, and where drivers are doing devm_clk_get*() immediately > followed by clk_prepare_enable(), combine them into devm_clk_get_*enabled(). > > sdhci_pltfm_register() and sdhci_pltfm_unregister() are not paired functions. > That are just helpers and effectively get renamed: > > sdhci_pltfm_register() -> sdhci_pltfm_init_and_add_host() > sdhci_pltfm_unregister() -> sdhci_pltfm_remove() > > Please note, the patches are based on top of some > "Convert to platform remove callback returning void" > patches by Yangtao Li, which were posted here: > > https://lore.kernel.org/linux-mmc/20230727070051.17778-1-frank.li@vivo.com/ > > Patches can also be found here: > > https://github.com/ahunter6/linux/commits/sdhci-pltfm-cleanup-1 All look good to me, thanks! Reviewed-by: Andy Shevchenko > Adrian Hunter (16): > mmc: sdhci-pltfm: Add sdhci_pltfm_remove() > mmc: sdhci-bcm-kona: Use sdhci_pltfm_remove() > mmc: sdhci-brcmstb: Use sdhci_pltfm_remove() > mmc: sdhci-cadence: Use sdhci_pltfm_remove() > mmc: sdhci-dove: Use sdhci_pltfm_remove() > mmc: sdhci_f_sdh30: Use sdhci_pltfm_remove() > mmc: sdhci-iproc: Use sdhci_pltfm_remove() > mmc: sdhci-of-arasan: Use sdhci_pltfm_remove() > mmc: sdhci-of-at91: Use sdhci_pltfm_remove() > mmc: sdhci-of-esdhc: Use sdhci_pltfm_remove() > mmc: sdhci-of-hlwd: Use sdhci_pltfm_remove() > mmc: sdhci-of-sparx5: Use sdhci_pltfm_remove() > mmc: sdhci-pxav2: Use sdhci_pltfm_remove() > mmc: sdhci-st: Use sdhci_pltfm_remove() > mmc: sdhci-pltfm: Remove sdhci_pltfm_unregister() > mmc: sdhci-pltfm: Rename sdhci_pltfm_register() > > drivers/mmc/host/sdhci-bcm-kona.c | 12 +++++++++++- > drivers/mmc/host/sdhci-brcmstb.c | 18 +++++------------- > drivers/mmc/host/sdhci-cadence.c | 17 ++++------------- > drivers/mmc/host/sdhci-dove.c | 8 ++------ > drivers/mmc/host/sdhci-iproc.c | 14 +++----------- > drivers/mmc/host/sdhci-of-arasan.c | 4 +++- > drivers/mmc/host/sdhci-of-at91.c | 2 +- > drivers/mmc/host/sdhci-of-esdhc.c | 2 +- > drivers/mmc/host/sdhci-of-hlwd.c | 4 ++-- > drivers/mmc/host/sdhci-of-sparx5.c | 17 ++++++----------- > drivers/mmc/host/sdhci-pltfm.c | 14 ++++++-------- > drivers/mmc/host/sdhci-pltfm.h | 8 ++++---- > drivers/mmc/host/sdhci-pxav2.c | 19 ++++++------------- > drivers/mmc/host/sdhci-st.c | 4 +++- > drivers/mmc/host/sdhci_f_sdh30.c | 2 +- > 15 files changed, 58 insertions(+), 87 deletions(-) > > > Regards > Adrian -- With Best Regards, Andy Shevchenko