From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Dirk Behme <dirk.behme@de.bosch.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: tmio: comment the ERR_PTR usage in this driver
Date: Tue, 5 Mar 2024 11:58:26 +0100 [thread overview]
Message-ID: <Zeb60iSJX-oY7l9a@shikoro> (raw)
In-Reply-To: <20240305105623.3379-2-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
> + /* Ready for new mrqs */
> + host->mrq = NULL;
> host->clk_cache = ios->clock;
For the record: I think these two statements should be swapped. First
set the new value, then allow new mrqs. However, I want to test this
change internally before submitting it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-05 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 10:56 [PATCH] mmc: tmio: comment the ERR_PTR usage in this driver Wolfram Sang
2024-03-05 10:58 ` Wolfram Sang [this message]
2024-03-05 12:14 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zeb60iSJX-oY7l9a@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=dirk.behme@de.bosch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox