From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A01D474E11 for ; Tue, 21 May 2024 12:52:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716295934; cv=none; b=GssKTYh5993yk/IZBkDtydDrWLXgUi/1sv7J1U6mgBGp/B/nDyXP0P2XBDB3kH9fDnmNDAfSNmjrxFZUSzVcbaXXd7xNet6hPIBeiZuTPA2dkar1wbpBll6KeGj601J6btLdyB65SkXtnBdxYoMisGury5xKMLgRy5iXCii6Bl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716295934; c=relaxed/simple; bh=cf5jWdMCCzC70EWwqirmwWz9mPNpeT6ra6qZ/BPw9fI=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bBcdPBJ82Ln+anPEq6h/HsaYO8Sd/0QoJNWIRvPkx0hotHJ9hHG/JQrmPLTO8HjlKDRfrSQS5ulFu/T+wY3veofxg3nfFvoqcUqfKck3Eiz0/jokoxc7DRsiwtgTz9E7Dn8m9p+eqaAka48XwiF9wFsiq2KRjRLrYhqXBu9nojM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ANPrTSxD; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ANPrTSxD" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2e6f2534e41so38640211fa.0 for ; Tue, 21 May 2024 05:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716295931; x=1716900731; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=1u5xJDOD57W6YVCnN4RepdIN+phyLa7DjVqYRoxfZgU=; b=ANPrTSxDgeAVaq571MqfgqLF8iE5hqp7M+RYWFQ7w4tVq0RIH+lCsMNCh9yc7zqmke zyuqJXTmAXa7yW0pF2S8xlpXHHNi15ofDcJfC9aOP6AkcVpQhr+fBPoIZG3jJ8TvLAvw YhLjs7pJe642qaEXRqEp0sNvRetno0SrTRpyzGAUTn5YtY0fQfO29ymnhzaRFXHx9PjB CcHNkZoZnXSIhVWLuL7KA/XZs3JZUlXCppnxb8q4Fu41ATH/qI1IUm92EYiO9sWhbTN6 wJG/BJpaXyDfY2eKv7CReeFMzbLiCOTw+LYAyCPhVhf+j9lvbaDy0Fhs7wYSGAkPblaC Wi8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716295931; x=1716900731; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1u5xJDOD57W6YVCnN4RepdIN+phyLa7DjVqYRoxfZgU=; b=arDTK5DFGknCiks9rjnIoNk8WiCK7hxGW33fsehqiqCM6RbnNDPoVe8S5jdQX21AYl jCQkNa4C1EoYIs06Hf5dv03z+XIklDYG1KD/kexrRTQWP6A7hE3eAO+nnPxHXpM+uOe8 oPTYOG79ZYJyc9ufJU+8eqKIiY9AqucDfP9piKe+16Q9wf6udMYOJ+xckDIdMkVSVz5n D7kQRrjT4YnVjgZ8wZKz1bNreqZn3lSZWCB+auKOwU2a41GHBnTAHajNMhFNRzbe/3g/ y4XnuLtN3vGPn+gaB9W8axBx0SR5KqyqbmpgJ6V1E8J+l9JQkqsWfP3dFREgYQ7Drtbe 5ciw== X-Forwarded-Encrypted: i=1; AJvYcCU2H8MGLmjXUBLQje7BzmcFK58q+hsEuhap12BxWIUPfgj561OY1u1xklno6NKQHFQwS3kk45/5+4uvg6LPI+n+om+AUPZy4LdP X-Gm-Message-State: AOJu0YyE1zmyIrBPRpifSNn1r1cNIyGrKJAxadnxoz0VQm6LcBruLESC 68F5mcKQ8pG3IFxV8ovtZLPCzfc16E78xFSHH9KYbAVPgZ6WSAtyp9+xSnKgbQM= X-Google-Smtp-Source: AGHT+IGWqjR12HPSB0jzPyPqMM3bUylbm55ZAq4klh7qS446LYCfduZoAUBb6DBdgrKY9LqhUuIk0w== X-Received: by 2002:a2e:958f:0:b0:2e2:9d0:9295 with SMTP id 38308e7fff4ca-2e51fd41f7emr207167051fa.8.1716295930722; Tue, 21 May 2024 05:52:10 -0700 (PDT) Received: from localhost (host-87-18-209-253.retail.telecomitalia.it. [87.18.209.253]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-574f6b8b9d7sm8750595a12.82.2024.05.21.05.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 05:52:10 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 21 May 2024 14:52:20 +0200 To: Stefan Wahren Cc: Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Marc Zyngier , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v3 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller Message-ID: Mail-Followup-To: Stefan Wahren , Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Marc Zyngier , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 13:56 Tue 21 May , Stefan Wahren wrote: > Hi Andrea, > > Am 21.05.24 um 10:35 schrieb Andrea della Porta: > > The BCM2712 has an SDHCI capable host interface similar to the one found > > in other STB chipsets. Add the relevant compatible string. > > > > Signed-off-by: Andrea della Porta > > --- > > Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > index cbd3d6c6c77f..d584a7ea707a 100644 > > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > @@ -13,6 +13,10 @@ maintainers: > > properties: > > compatible: > > oneOf: > > + - items: > > + - enum: > > + - brcm,bcm2712-sdhci > > + - const: brcm,sdhci-brcmstb > sorry i didn't noticed in V2, but why can't we just extend the second > items list? Hi Stefan, I initially thought that the two different item lists represent two different controller families, but now that you point that out, I'm more and more convinced that probably we can shorten the representation as you are suggesting, adding 'brcm,bcm2712-sdhci' to the second item list enum. Will be so in V4. Many thanks, Andrea > > - items: > > - enum: > > - brcm,bcm7216-sdhci >