public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Philip Li <philip.li@intel.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Joern Engel <joern@lazybastard.org>,
	Keith Busch <kbusch@kernel.org>, "Jens Axboe" <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Wolfram Sang <wsa-dev@sang-engineering.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<linux-nvme@lists.infradead.org>, <oe-kbuild-all@lists.linux.dev>
Subject: Re: [PATCH v2 6/6] mtd: parser: add support for Airoha parser
Date: Tue, 6 Aug 2024 17:23:43 +0800	[thread overview]
Message-ID: <ZrHrn9NzeOhp+Sdl@rli9-mobl> (raw)
In-Reply-To: <66b0b109.050a0220.93681.d015@mx.google.com>

On Mon, Aug 05, 2024 at 04:54:45AM +0200, Christian Marangi wrote:
> On Mon, Aug 05, 2024 at 06:52:04AM +0800, kernel test robot wrote:
> > Hi Christian,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on robh/for-next]
> > [also build test ERROR on linus/master v6.11-rc1 next-20240802]
> > [cannot apply to mtd/mtd/next mtd/mtd/fixes]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/dt-bindings-nvme-Document-nvme-card-compatible/20240805-014740
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> > patch link:    https://lore.kernel.org/r/20240804174414.18171-7-ansuelsmth%40gmail.com
> > patch subject: [PATCH v2 6/6] mtd: parser: add support for Airoha parser
> > config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20240805/202408050612.Ya1m6REu-lkp@intel.com/config)
> > compiler: xtensa-linux-gcc (GCC) 14.1.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240805/202408050612.Ya1m6REu-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202408050612.Ya1m6REu-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/mtd/parsers/ofpart_airoha.c: In function 'airoha_partitions_post_parse':
> >    drivers/mtd/parsers/ofpart_airoha.c:33:16: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
> >       33 |         prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> >          |                ^~~~~~~
> > >> drivers/mtd/parsers/ofpart_airoha.c:33:14: error: assignment to 'struct property *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> >       33 |         prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> >          |              ^
> > 
> > 
> > vim +33 drivers/mtd/parsers/ofpart_airoha.c
> > 
> >     10	
> >     11	int airoha_partitions_post_parse(struct mtd_info *mtd,
> >     12					 struct mtd_partition *parts,
> >     13					 int nr_parts)
> >     14	{
> >     15		struct mtd_partition *part;
> >     16		int len, a_cells, s_cells;
> >     17		struct device_node *pp;
> >     18		struct property *prop;
> >     19		const __be32 *reg;
> >     20		__be32 *new_reg;
> >     21	
> >     22		part = &parts[nr_parts - 1];
> >     23		pp = part->of_node;
> >     24	
> >     25		/* Skip if ART partition have a valid offset instead of a dynamic one */
> >     26		if (!of_device_is_compatible(pp, "airoha,dynamic-art"))
> >     27			return 0;
> >     28	
> >     29		/* ART partition is set at the end of flash - size */
> >     30		part->offset = mtd->size - part->size;
> >     31	
> >     32		/* Update the offset with the new calculate value in DT */
> >   > 33		prop = kzalloc(sizeof(*prop), GFP_KERNEL);
> > 
> > -- 
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> 
> Mhhh somehow I can't repro this with instructions?

Hi Ansuel, would you mind sharing the steps of reproduce? I can reproduce this with steps
described in the repro link [1]

[1] https://download.01.org/0day-ci/archive/20240805/202408050612.Ya1m6REu-lkp@intel.com/reproduce

> -- 
> 	Ansuel
> 

  reply	other threads:[~2024-08-06  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04 17:44 [PATCH v2 0/6] mtd: improve block2mtd + airoha parser Christian Marangi
2024-08-04 17:44 ` [PATCH v2 1/6] dt-bindings: nvme: Document nvme-card compatible Christian Marangi
2024-08-04 17:44 ` [PATCH v2 2/6] nvme: assign of_node to nvme device Christian Marangi
2024-08-04 17:44 ` [PATCH v2 3/6] dt-bindings: mmc: add property for partitions node in mmc-card node Christian Marangi
2024-08-04 17:44 ` [PATCH v2 4/6] block2mtd: attach device OF node to MTD device Christian Marangi
2024-08-04 17:44 ` [PATCH v2 5/6] dt-bindings: mtd: Add Documentation for Airoha fixed-partitions Christian Marangi
2024-08-04 17:44 ` [PATCH v2 6/6] mtd: parser: add support for Airoha parser Christian Marangi
2024-08-04 22:41   ` kernel test robot
2024-08-04 22:52   ` kernel test robot
2024-08-05  2:54     ` Christian Marangi
2024-08-06  9:23       ` Philip Li [this message]
2024-08-06 11:32         ` Christian Marangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrHrn9NzeOhp+Sdl@rli9-mobl \
    --to=philip.li@intel.com \
    --cc=ansuelsmth@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hch@lst.de \
    --cc=joern@lazybastard.org \
    --cc=kbusch@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=sagi@grimberg.me \
    --cc=tsbogend@alpha.franken.de \
    --cc=ulf.hansson@linaro.org \
    --cc=vigneshr@ti.com \
    --cc=wsa-dev@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox