From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937C3EB64D9 for ; Tue, 20 Jun 2023 01:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229453AbjFTBob (ORCPT ); Mon, 19 Jun 2023 21:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbjFTBoa (ORCPT ); Mon, 19 Jun 2023 21:44:30 -0400 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC8A3E6C for ; Mon, 19 Jun 2023 18:44:28 -0700 (PDT) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C7F43861F6; Tue, 20 Jun 2023 03:44:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1687225466; bh=TzcnGnaD/AWvHkTiIiS9YoEXARz6/aQ6X/vVH/KbKLM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=phzMKChivizlPUDd/txi7j+2P5p8xL2Gj+DCsBsDF/llPpaH1krCpIrT0gzLhwQqg Fpsch154iBo9LNVxFW56Rxkau5675yi45SfF+ordaTe35XEYMCvvJJ10hmUz9e3eKR BTPXlU+jOX1o6HEnH0MbfTBZJfLOFebb7+PRY8x1Rz4DwetFDY/P9MmJBviUC4OjW9 4Cuv7/UH4NRS9npXM23hqjiQzVDrmgVBNuIOQH2N92Ewh4DUGzlAUjdxT7OMKO3VOG qzDx+CqsHQTKWV4GQD5gk9QTAaUhh9Ce30lSlM+cXGae8NnB4d0285b4+ro+zkwKQ0 eICEc3w25oQVw== Message-ID: Date: Tue, 20 Jun 2023 03:44:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] [RFC] Revert "mmc: core: Fixup support for writeback-cache for eMMC and SD" To: Ulf Hansson Cc: Adrian Hunter , linux-mmc@vger.kernel.org, =?UTF-8?Q?Christian_L=c3=b6hle?= , Avri Altman , Jens Axboe , Michael Wu , Ming Lei , Seunghui Lee , xander_li@kingston.com.tw References: <20230531002740.1235620-1-marex@denx.de> <29a5f24d-2b8c-8387-8c11-601af8e13940@denx.de> <4c8d84ae-c8d0-fa12-81c6-a47382684d73@intel.com> <3bd65a30-756d-e7ee-ce77-e5ebfe6b6e30@denx.de> <75ab27e9-9203-f59b-c720-99bfa992bb9b@intel.com> <0029620e-4d22-d8f9-5566-4b1ea7f05bae@denx.de> <6423ae91-7585-b141-960a-f8cfd4b23538@denx.de> <3a660f13-5397-cb7e-49d3-b464ec677e69@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 6/16/23 12:33, Ulf Hansson wrote: Hi, [...] >>>>>> I have been trying to follow the progress around this matter. If I >>>>>> understand correctly we are leaning towards making a card quirk for >>>>>> this particular SD, to avoid us from turning on and using a broken >>>>>> cache feature. >>>>>> >>>>>> Or what are you thinking? >>>>> >>>>> That is probably the simplest option. >>>> >>>> Just give me a day or two to test the other newer card. >>>> >>>> What would you base that quirk off of ? Date ? We don't know when the >>>> "fixed" cards started to be produced . >>> >>> Right. It seems like the best we can do is to make a quirk for that >>> particular version of card that you proved to have failed. >> >> I just sent a few more data points . It is either date, or C_SIZE, or >> ERASE_TIMEOUT (if I decode it right). I can also just archive the card, >> since we have sample size of the defective card equal 1 . It could just >> be a defective card after all, although the fact that only cache would >> be defective is unusual. > > I wouldn't mind having a card quirk and to use "date". But it looks > like it's your call to make. :-) I sent the quirk patch: [PATCH] mmc: Add MMC_QUIRK_BROKEN_SD_CACHE for Kingston Canvas Go Plus from 11/2019 It seems it is a bit bigger than I though it would originally be.