From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH 1/3] mmc: core: activate pre-erased multiple write support for sd card Date: Fri, 27 Oct 2017 09:52:00 +0800 Message-ID: References: <1506483638-115756-1-git-send-email-shawn.lin@rock-chips.com> <699af9d0-c69b-e02b-54c1-7b0dd3f5369c@rock-chips.com> <7f44a238-28f6-a020-cfda-9696a873b2ec@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from lucky1.263xmail.com ([211.157.147.133]:49541 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbdJ0BwC (ORCPT ); Thu, 26 Oct 2017 21:52:02 -0400 In-Reply-To: <7f44a238-28f6-a020-cfda-9696a873b2ec@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Adrian Hunter , Ulf Hansson Cc: shawn.lin@rock-chips.com, Jaehoon Chung , Wolfram Sang , "Steven J. Hill" , Jan Glauber , "linux-mmc@vger.kernel.org" Hi Adrian, On 2017/10/26 19:32, Adrian Hunter wrote: > On 26/10/17 13:46, Ulf Hansson wrote: >> On 26 October 2017 at 03:19, Shawn Lin wrote: >>> Hi, Ulf >>> >>> On 2017/9/27 11:40, Shawn Lin wrote: >>>> >>>> Per SD specification version 4.10, section 4.3.4, it says "pre-erased >>>> (ACMD23) will make a following Multiple Block Write operation faster >>>> compared to the same operation without preceding ACMD23". ACMD23 is >>>> mandatory for all sd cards and the spec also says "Command STOP_TRAN >>>> (CMD12) shall be used to stop the transmission in Write Multiple Block >>>> whether or not the preerase (ACMD23) feature is used." >>> >>> >>> Ping... :) >> >> Hi Shawn, >> >> Actually I was waiting for confirmation from Jan about his tests. >> >> However, overall the series looks reasonable to me. > > Obviously the blk-mq patches do not have support for this. Please apply the > blk-mq patches first. Ok, I will rebase this on the top of your V12 of cqe+mq patchset. > > What were the performance numbers? I did have some test result about performance, but actually there were not any gain or regression from the result, so I didn't provide the numbers as it doesn't seem to improve te performance but just change the behaviour for how the sd cards do multiple write w/o CMD23 support. > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >