From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-mmc-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 09560C77B7A
	for <linux-mmc@archiver.kernel.org>; Tue,  6 Jun 2023 11:42:22 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236704AbjFFLmV (ORCPT <rfc822;linux-mmc@archiver.kernel.org>);
        Tue, 6 Jun 2023 07:42:21 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35232 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236784AbjFFLmU (ORCPT
        <rfc822;linux-mmc@vger.kernel.org>); Tue, 6 Jun 2023 07:42:20 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A92BF10C8;
        Tue,  6 Jun 2023 04:41:59 -0700 (PDT)
Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab])
        (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
         key-exchange X25519 server-signature RSA-PSS (4096 bits))
        (No client certificate requested)
        (Authenticated sender: kholk11)
        by madras.collabora.co.uk (Postfix) with ESMTPSA id 9CEAA6606E97;
        Tue,  6 Jun 2023 12:41:57 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
        s=mail; t=1686051718;
        bh=GW+DvE4vtnoebxP8kfMeV8thnfGpbViwiHIrEXXP98s=;
        h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
        b=JeAuN3ekhZhjUz9QB+rbJxCDecQl3k3FnM8P7dW/awY/UiUugXjx4E6/veOnZMJsz
         ZTmjDHuzoWFzCh3a+0EGYcLDv6pacglXfwiD4DO0PlLqW5HnbKKH52HwqDa5KAIu6S
         9a6sFzAfJ9YW3IDzk9dEAC3BML384bLfGA11IBP5LLMydJJYdR+WTVKuhDzpq8nBxR
         nn0U9NEiZXl9y+e4+NRmKaoeSI3yAmR2qpVfHmbB68bSGQc4sJyhKw0iKIuLH1NfTv
         LjYWCfYICF03k0OEVTHeQvMxHCAgqS0IZ1/bcx5RlIzdZ6SJ+JqOSHQZSXhcmGf2ki
         P6TP7jTBWO4eA==
Message-ID: <a8d1f20c-9ff0-2796-d31f-7ef6f11ee6a4@collabora.com>
Date:   Tue, 6 Jun 2023 13:41:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v5 1/1] mmc: mtk-sd: reduce CIT for better performance
Content-Language: en-US
To:     Wenbin Mei <wenbin.mei@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Chaotian Jing <chaotian.jing@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ritesh Harjani <riteshh@codeaurora.org>,
        Asutosh Das <asutoshd@codeaurora.org>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        kernel test robot <lkp@intel.com>
References: <20230606113249.28057-1-wenbin.mei@mediatek.com>
 <20230606113249.28057-2-wenbin.mei@mediatek.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230606113249.28057-2-wenbin.mei@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-mmc.vger.kernel.org>
X-Mailing-List: linux-mmc@vger.kernel.org

Il 06/06/23 13:32, Wenbin Mei ha scritto:
> CQHCI_SSC1 indicates to CQE the polling period to use when using periodic
> SEND_QUEUE_STATUS(CMD13) polling.
> Since MSDC CQE uses msdc_hclk as ITCFVAL, so driver should use hclk
> frequency to get the actual time.
> The default value 0x1000 that corresponds to 150us for MediaTek SoCs, let's
> decrease it to 0x40 that corresponds to 2.35us, which can improve the
> performance of some eMMC devices.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>