Re: [PATCH 8/8] arm64: defconfig: Enable IPQ5424 SoC base configs

Dmitry Baryshkov
2024-09-25T21:31:44Z

On Thu, Sep 26, 2024 at 12:34:56AM GMT, Sricharan Ramabadhran wrote:
>
>
> On 9/13/2024 6:23 PM, Dmitry Baryshkov wrote:
> > On Fri, Sep 13, 2024 at 05:42:50PM GMT, Sricharan R wrote:
> > > From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > >
> > > Enable the clock and pinctrl configs for Qualcomm IPQ5332 SoC
> >
> > Please name the device rather than the platform. The defconfig affects
> > all users, so it should be justified.
> >
> Sorry, to understand correctly, you mean to use the board name here ?

Yes, the board which is generally accessible, if possible. You are
increasing kernel size for everybody using defconfig, so at least it
should be obvious, who is benefiting from that.

>
> > >
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> >
> > Usual comment.
> ok, will fix.
>
> Regards,
> Sricharan

--
With best wishes
Dmitry