Re: [PATCH 2/8] dt-bindings: pinctrl: qcom: add IPQ5332 pinctrl

Sricharan Ramabadhran
2024-09-20T11:57:50Z

[..]

>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq5424-tlmm.yaml
>> @@ -0,0 +1,115 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/qcom,ipq5424-tlmm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm IPQ5424 TLMM pin controller
>> +
>> +maintainers:
>> + - Bjorn Andersson <andersson@kernel.org>
>> + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Sorry, not me. I don't have this hardware.
>
ok, will remove
>> +
>> +description: |
>
> Drop |
>
ok
>> + Top Level Mode Multiplexer pin controller in Qualcomm IPQ5424 SoC.
>> +
>> +allOf:
>> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: qcom,ipq5424-tlmm
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + gpio-reserved-ranges:
>> + minItems: 1
>> + maxItems: 26
>
> 25, I believe is the max in such case
>
ok
>> +
>> + gpio-line-names:
>> + maxItems: 50
>> +
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Thanks

Regards,
Sricharan