Re: [PATCH 1/9] dt-bindings: clock: add Qualcomm IPQ5210 GCC

Krzysztof Kozlowski
2026-03-13T13:22:08Z

On Wed, Mar 11, 2026 at 03:15:43PM +0530, Kathiravan Thirumoorthy wrote:
> Add binding for the Qualcomm IPQ5210 Global Clock Controller.
>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
> .../bindings/clock/qcom,ipq5210-gcc.yaml | 62 ++++++++++
> include/dt-bindings/clock/qcom,ipq5210-gcc.h | 126 ++++++++++++++++++++
> include/dt-bindings/reset/qcom,ipq5210-gcc.h | 127 +++++++++++++++++++++
> 3 files changed, 315 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5210-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5210-gcc.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..aeb5d9a3f8322d5d36d2fd19a1d23b275efc34b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq5210-gcc.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,ipq5210-gcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller on IPQ5210
> +
> +maintainers:
> + - Bjorn Andersson <andersson@kernel.org>
> + - Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> +
> +description: |
> + Qualcomm global clock control module provides the clocks, resets and power
> + domains on IPQ5210
> +
> + See also::

Just a single ':'

> + include/dt-bindings/clock/qcom,ipq5210-gcc.h
> + include/dt-bindings/reset/qcom,ipq5210-gcc.h

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof