Re: [PATCH 2/9] clk: qcom: add Global Clock controller (GCC) driver for IPQ5210 SoC

Kathiravan Thirumoorthy
2026-03-13T08:42:13Z

On 3/11/2026 8:20 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 11, 2026 at 03:15:44PM +0530, Kathiravan Thirumoorthy wrote:
>> Add support for the global clock controller found on IPQ5210 SoC.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>> drivers/clk/qcom/Kconfig | 8 +
>> drivers/clk/qcom/Makefile | 1 +
>> drivers/clk/qcom/gcc-ipq5210.c | 2641 ++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 2650 insertions(+)
>>
>> +
>> +static struct clk_alpha_pll gpll4_main = {
>> + .offset = 0x22000,
>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT_EVO],
>> + .clkr = {
>> + .enable_reg = 0xb000,
>> + .enable_mask = BIT(2),
>> + .hw.init = &(const struct clk_init_data) {
>> + .name = "gpll4_main",
>> + .parent_data = &gcc_parent_data_xo,
>> + .num_parents = 1,
>> + .ops = &clk_alpha_pll_ops,
>> + .flags = CLK_IS_CRITICAL,
> comment, why?

Sure, let me add something like below in the next spin. Will that be okay?

/*
* There are no consumers for this source in kernel yet,
* (will be added soon), so the clock framework
* disables this source. But some of the clocks
* initialized by boot loaders uses this source. So we
* need to keep this clock ON. Add the
* CLK_IS_CRITICAL flag so the clock will not be
* disabled. Once the consumer in kernel is added, we
* can get rid of this flag.
*/

Thanks,

Kathiravan T.

>
>> + },
>> + },
>> +};