From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1215923BD00 for ; Thu, 4 Sep 2025 15:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756999763; cv=none; b=n6OQLehNEOTPKIkW0QTaJN6MFRsDYhW7O0IljGY0N8j2+stvqYITrq6m0CatUbTIDM1tEjn08tY3LwG/33tsGAztgD5PJRh6sOvy3F5pQWMmVOKjgc3avhn4TZH303Qm/OYuIaTqoFHaYPwrriDQ2HW41kPq1+1UJXVin6A+cq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756999763; c=relaxed/simple; bh=EUUOJm8+pqfJE0C02BV4F6cE3SBmlMX62RiOmXxnlyg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f8Z+C6GNpYf+hWo5KLav5rWoi+f+KjDyiVyVX/7k/FL4hTr92u4T+OMhC6K3Pw4S/fzcvpOHxt10Vtuy/9zs1yYDB8Rhgk+HXAEv3e3QZ/3xyjyzHpb9iK04IWE8d+Y6x4pCWS6CFtcr1LO3SpS4BqrxEzHECHtR9Nbs8/4wclk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JykgU5gr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JykgU5gr" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5849XB6V013631 for ; Thu, 4 Sep 2025 15:29:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aCKrmPJEFXGT0WYbXHZg3VTYOIhYkJFe7iTrbDkI7Yg=; b=JykgU5grP0LzChRS jo5fMTmzga1W8yeVxF9tViRBvkFXCJtHR7aVYgmLnoqxhr9ttxNTxlGbZsS4LdRN kpsDb53P3r3X5KkbWDFxac815aVm1cUa1fLkD+NMSL3FOGhM9YAkXrkyeUJ6g3r3 go9383tqDVDZUo6MbK/JJTuRcmNg1ikvHWaGxgVpgdiWVZtxFlqnPTviuC+i6zOb orDfQhNzgKA3FudfFzcbgNh+zFlz7oubp3DMwkUV0jJ773Z7HdaX0J8xPyo1ow8k K3nxAlgQPa+EMv+QseXkgHtUGVQYJJTg5oHDfA744/Dzy+cff7TLAMoZHK2yoRJS uYvHtQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48w8wybv3m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 04 Sep 2025 15:29:18 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-32bbacf6512so59243a91.1 for ; Thu, 04 Sep 2025 08:29:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756999757; x=1757604557; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aCKrmPJEFXGT0WYbXHZg3VTYOIhYkJFe7iTrbDkI7Yg=; b=w5b9/2zbl1Fj/tbGf+ofuLhkyJeuRpppqC7OXoXaaZBoW0Hrhsz5IFs6f2L5Xpmvnj aiX88JmqbwJO9W+0YtZB6ssj91/jVtekqJ6t37/OuBTGG7uDwlZkZ5ljw64Q5VLYrJXh uOMEimH2UZLtMLFmCqn5BMr+CuPSF8Fgy0rwBkBH0gTFRJ8kaM8N6253Xsd0nFI7DG3j s51vxWnXJ8ICFc4/3AeJaDm6/VfCHMeb8ef/xUWiW9BFPZ/FCapmrwlwA0pxYMLIQgQF BW8wpGL1iewhtu7ERtX8pYt9q9WW968PV6FJepWQRbRMrNrgltUVZTMAsDJZNC9KEwOn kGpg== X-Forwarded-Encrypted: i=1; AJvYcCWl6WyyYekehYf6REqIB1pH6k7KbL8FOr1Q8OZOGf/WbTgatbaKefInGSV7FBf15W/BA8yLaVEHlZw=@vger.kernel.org X-Gm-Message-State: AOJu0YxuXeRxHi3Mbbm3kpjzI+jSNj11+qYb2aqzSqnCxc9oCjoE6GsP 0q9ykUuB9GnIWfeJaRDwm+qXqZ8KXlYc8PbswXF7AOmNe6/5PJfpoZmcs9GqC/VDBJLVskuLsBO M1n8Ujk+XoN8glOVvATWy2gYtEpHHKIVJRSu3LkaPQhhw3+rR8BpxRMda2nGDbHo= X-Gm-Gg: ASbGncsF6FLvKRO+dlOGjHMKxcxDdpKNdeCIuwqpe3rP6JsvsXubDZVdI5FMG8J3gpx 2zpC2ePV/QPkaeDsNqldelX46LcDWgauTe2ijm8SBcbdYiKzox1AbQLJ3SI0/66bphsXWJCDpMi XIHMOjwu2zVM6stIpsZu0L0anmaure+5Do23C43E04aRjQM14V0kR72c9eq8hsejIcdOtMa6vzc jadx14BcpKvSbqyQ+O7fiZQnCQ7h59V+1VRgOh5E1o/DE6dwLtTZpUJsPKu2Hq7ZDyLihal2nxy 4eH/50vyDZrfMSb3mNYu8Fty76dVf2DD0wFYWyLhDZFnPIERYxXeacyydkePFzVfwn5Y X-Received: by 2002:a17:902:d4c1:b0:24c:92b5:2175 with SMTP id d9443c01a7336-24c92b5262fmr76676005ad.24.1756999757441; Thu, 04 Sep 2025 08:29:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4JhBNWdG2V+TxgIDesrLMeTY0t0q4ahoJ30jB1TKaWOy2/eOV1xvyNkelIVpDUVQxYmrVWg== X-Received: by 2002:a17:902:d4c1:b0:24c:92b5:2175 with SMTP id d9443c01a7336-24c92b5262fmr76675745ad.24.1756999756970; Thu, 04 Sep 2025 08:29:16 -0700 (PDT) Received: from hu-wasimn-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-327c5fc5055sm22049502a91.14.2025.09.04.08.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Sep 2025 08:29:16 -0700 (PDT) Date: Thu, 4 Sep 2025 20:59:09 +0530 From: Wasim Nazir To: Konrad Dybcio , Dmitry Baryshkov Cc: Dmitry Baryshkov , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Richard Cochran , kernel@oss.qualcomm.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, Monish Chunara Subject: Re: [PATCH 2/5] arm64: dts: qcom: lemans: Add SDHC controller and SDC pin configuration Message-ID: References: <20250826-lemans-evk-bu-v1-0-08016e0d3ce5@oss.qualcomm.com> <20250826-lemans-evk-bu-v1-2-08016e0d3ce5@oss.qualcomm.com> <3b691f3a-633c-4a7f-bc38-a9c464d83fe1@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b691f3a-633c-4a7f-bc38-a9c464d83fe1@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=Ycq95xRf c=1 sm=1 tr=0 ts=68b9b04e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=7jlciowUQMUDIi_Z8n8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: rcq0Zw__jKj3rbAYYS2LgfHxLlj_0Edq X-Proofpoint-ORIG-GUID: rcq0Zw__jKj3rbAYYS2LgfHxLlj_0Edq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAxMDEwMSBTYWx0ZWRfX6OXwCGM+H3QQ qWm0AbrOXm9j+/hQ5dykPPjaKL4MG5vu3aWxhOrpFFhOEzfT8LrAMbGpMIGvxVErWdpN93vMBHz 1cx5tD06MFvhkQjtjCQcAhw7oedgPWmo6v3/lUJHNx5bwv+IXrUe9V+ZOIS+o331UQFsB7qUOnm fUBbGomWS3zTDDlfwWpEZchfozh+JRHVQtK03g6z7y+o4Oaboc/+SbvsOLjPHPRSPp5G30HWU3V uf96F3iYxDbdFKxn4B46Max2GEUsBdctqjAQghgJ68bFxsaPxu+++Z53eaNUvrxVA68SDw1AT+z xABZZiApmDZCYBpR8La8VEU1adZGix77F3QpLZOXcY3oJ3dAVM2yWx1p3Np0fDS0K6PQXgyDIrp h782kSB8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-04_05,2025-09-04_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509010101 On Thu, Sep 04, 2025 at 04:34:05PM +0200, Konrad Dybcio wrote: > On 9/4/25 3:35 PM, Dmitry Baryshkov wrote: > > On Wed, Sep 03, 2025 at 09:58:33PM +0530, Wasim Nazir wrote: > >> On Wed, Sep 03, 2025 at 06:12:59PM +0200, Konrad Dybcio wrote: > >>> On 8/27/25 3:20 AM, Dmitry Baryshkov wrote: > >>>> On Tue, Aug 26, 2025 at 11:51:01PM +0530, Wasim Nazir wrote: > >>>>> From: Monish Chunara > >>>>> > >>>>> Introduce the SDHC v5 controller node for the Lemans platform. > >>>>> This controller supports either eMMC or SD-card, but only one > >>>>> can be active at a time. SD-card is the preferred configuration > >>>>> on Lemans targets, so describe this controller. > >>>>> > >>>>> Define the SDC interface pins including clk, cmd, and data lines > >>>>> to enable proper communication with the SDHC controller. > >>>>> > >>>>> Signed-off-by: Monish Chunara > >>>>> Co-developed-by: Wasim Nazir > >>>>> Signed-off-by: Wasim Nazir > >>>>> --- > >>>>> arch/arm64/boot/dts/qcom/lemans.dtsi | 70 ++++++++++++++++++++++++++++++++++++ > >>>>> 1 file changed, 70 insertions(+) > >>>>> > >>>>> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > >>>>> index 99a566b42ef2..a5a3cdba47f3 100644 > >>>>> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > >>>>> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > >>>>> @@ -3834,6 +3834,36 @@ apss_tpdm2_out: endpoint { > >>>>> }; > >>>>> }; > >>>>> > >>>>> + sdhc: mmc@87c4000 { > >>>>> + compatible = "qcom,sa8775p-sdhci", "qcom,sdhci-msm-v5"; > >>>>> + reg = <0x0 0x087c4000 0x0 0x1000>; > >>>>> + > >>>>> + interrupts = , > >>>>> + ; > >>>>> + interrupt-names = "hc_irq", "pwr_irq"; > >>>>> + > >>>>> + clocks = <&gcc GCC_SDCC1_AHB_CLK>, > >>>>> + <&gcc GCC_SDCC1_APPS_CLK>; > >>>>> + clock-names = "iface", "core"; > >>>>> + > >>>>> + interconnects = <&aggre1_noc MASTER_SDC 0 &mc_virt SLAVE_EBI1 0>, > >>>>> + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_SDC1 0>; > >>>>> + interconnect-names = "sdhc-ddr", "cpu-sdhc"; > >>>>> + > >>>>> + iommus = <&apps_smmu 0x0 0x0>; > >>>>> + dma-coherent; > >>>>> + > >>>>> + resets = <&gcc GCC_SDCC1_BCR>; > >>>>> + > >>>>> + no-sdio; > >>>>> + no-mmc; > >>>>> + bus-width = <4>; > >>>> > >>>> This is the board configuration, it should be defined in the EVK DTS. > >>> > >>> Unless the controller is actually incapable of doing non-SDCards > >>> > >>> But from the limited information I can find, this one should be able > >>> to do both > >>> > >> > >> It’s doable, but the bus width differs when this controller is used for > >> eMMC, which is supported on the Mezz board. So, it’s cleaner to define > >> only what’s needed for each specific usecase on the board. > > > > `git grep no-sdio arch/arm64/boot/dts/qcom/` shows that we have those > > properties inside the board DT. I don't see a reason to deviate. > > Just to make sure we're clear > > I want the author to keep bus-width in SoC dt and move the other > properties to the board dt > I'll move the no-sdio and no-mmc properties to the board-specific device tree file, and keep the bus-width configuration in the SoC-level file. -- Regards, Wasim