Re: [PATCH] mmc: core: annotate implicit fall through

Gustavo A. R. Silva
2019-01-14T21:29:05Z

On 1/14/19 2:42 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> In this particular case rewrote the comment to start with the string "fall
> through", so as to match the regular expression expected by GCC. Truncate
> the comment slightly to fit the max line length of 80 characters.
>
> This commit remove the following warning:
>
> drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks, Mathieu.

> ---
> drivers/mmc/core/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index f57f5de54206..0052d6fed7c8 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -194,7 +194,7 @@ int mmc_of_parse(struct mmc_host *host)
> switch (bus_width) {
> case 8:
> host->caps |= MMC_CAP_8_BIT_DATA;
> - /* Hosts capable of 8-bit transfers can also do 4 bits */
> + /* fall through - Hosts capable of 8-bit can also do 4 bits */
> case 4:
> host->caps |= MMC_CAP_4_BIT_DATA;
> break;
>