Re: [PATCH v17 06/17] mmc: renesas_sdhi: Introduce renesas_sdhi_hw_info to abstract clock mask

[wsa+renesas <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

Hi Biju,

> Ok, I have prototyped with renesas_sdhi_of_data and tmio_mmc_data as per your 
> suggestion

Cool, thank you!

> 
> The below variables[1] added to struct tmio_mmc_data and
> the feature flags[2]. Please let me know is it ok or not?
> 
> [1]
> 	u64				clk_mask;
> 	unsigned int 		max_divider;
> 	u32				osel_tmpout;
> 
> [2]
>  /* Some controllers have tuning delay */
> #define TMIO_MMC_TUNING_DELAY		BIT(13)
> 
> /* Some controllers have internal divider */
> #define TMIO_MMC_INTERNAL_DIVIDER	BIT(14)
> 
> /* Some controllers have hw adjustment delay */
> #define TMIO_MMC_HWADJ2			BIT(15)
> 
> /* Some controllers have HS400mode2  */
> #define TMIO_MMC_HS400MODE2		BIT(16)
> 
> /* Some controllers have HS400ES  */
> #define TMIO_MMC_HS400ES		BIT(17)

Yes, looks good so far from what I understand about the differences.
Keep going, please.

> Agreed, it now works without hw_info struct.

Awesome!

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]