From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0A723AEF54 for ; Thu, 27 Aug 2026 21:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787865113; cv=none; b=aW3wm1JQ9VtgpXRT/drmFfCU99wsaBgI3r2zSXeHddxUME8TCWJafq/PQG5YURd2hTyLuvLEzNz7y1rsOO32PuOPqITnCKNlCIHoYsuZyM75kNUT8yGZRthPyhLeYLG5LywHvbXIcxcviHDPGgOtcyQqhGdbtOTkq2wiNOm5yVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787865113; c=relaxed/simple; bh=5DiTONfLGfzVRBMIwWQ+35enC6CcVIcxY6kW47nLHjM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CyZ6d4FCLIe2pCbwI7DC5PdruqFzj97NDWoEc+NotnA8hur9uTZnTcxKOwgUHY/bJIcoB0CRl/T11mBdJukNBlQhfPFsyEU7ONr98ZjaN1hNdhJE9JYud1JtQD9A59aMz7EwGA0lTR9chyxKVhMP/gZw5Q23lBkGbtPG0v7nVII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QsxacJvx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XXU7XOHI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QsxacJvx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XXU7XOHI" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67RJLuqt848976 for ; Thu, 27 Aug 2026 21:11:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=b4qSUBRWwKynQruKg+4d/vg2 0odJ4RqXuTZyRs4vdw8=; b=QsxacJvx+dPTgQNyyBE5KeO2KP+t/kNcNazm9/+y vwwEH4yaSuEdezsV9Y6Z4W6Fgh4980zebKRwQUdZqqr0HWOX0prWhOo7B3C5gJIC VVJ++4cJNAH4Xqngu6VcwsN8O/SXETnsVGds3f378AhHvfHlTuL0HOe4Yahy5ars QQ7P3jGeFtinxAHYVVCwIMzK8lH5j6WVbNYiHP4//G0+WFGoNndhDysEBhMp33ow gzT4DcxOB1e6ObT0QRcfkNeWyYZdI7tGJ8tQ1b+n6vZBM0LefFKl+JGq3sjg/rtc GBc67qjWe9bwO20/eeU9DXmEoVyPqZq8S58KPGTMWJl67g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ganr6a04u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Aug 2026 21:11:50 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d63c16fc5bso5481825ad.1 for ; Thu, 27 Aug 2026 14:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787865110; x=1788469910; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=b4qSUBRWwKynQruKg+4d/vg20odJ4RqXuTZyRs4vdw8=; b=XXU7XOHIVcqS7VH+GMf9iX4dt//5uGkjtIcRfIr+zQen6LM/Ae2GMJFyiFCD+r39hG jY49mFrDtBTcg4IqEi0co5F2G/Loe6ZZrgaL+/M+KCy1CVznZF98HQ+80V01UpTD2ID8 rLklnkICSmbH6Nf/25YOt9iz6NDDxzcSTpTsAGBl+SfhREDNvJ0OGfUgfVi0pFsJBypM 9LYcLOkFs2ezyGk4ma6yQARQuKhaSY+2Q6Jlsms50Co6C3F4351GLB3yRlWQGUWLwSZJ RYjrqmlUhxrloN5YCYLW7zX776wYEMU/Wgf4J+zmrk10FEQoiNimkeXLo3uhBH7jmDbl qRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787865110; x=1788469910; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=b4qSUBRWwKynQruKg+4d/vg20odJ4RqXuTZyRs4vdw8=; b=hOTfLvEcW3oagfEqknF52j6doEUb2HKZDUbkGdzyxx5HiJuD1hnf1FDyQVta7ChXJD SzL6M/X73TAMlKsR/Ukm0fVMqqcdttt5S7vaDmm1Ghizplt3LRJPWv8rE/Udx8qTHrcg Ho7SJqrircsWgyeAAcnBHqK08VWer+HabVkufBKyDzvWnG3HErXFbkjIi+qyNIIVPH1G cPojRjmGJwTg5fOCRB/lRmxDowpPy0HAb6TzGFcVBLI8qnSCyd38EXbUEpS9qX56k77J eRPIxbx0vBxqUHvTkjUY7Y7Zu05cDxM+FQDl81w9ICcQyQOxDqNDipOIJsGbStUZ33/8 Pzsg== X-Forwarded-Encrypted: i=1; AHgh+RqQZm7+N4vOkvham5DqR9S0lZHiMhUckryJvqUbfV1+ucZVlZe5QEi+4PD6BbWJDAYeETk4MVdEpTI=@vger.kernel.org X-Gm-Message-State: AFuF++ljcPj85x+drMwJVNk1jxhFpZ/KlS3o7MVvgPz81w0eW/96QqMS g1HJby2qCwCyKiY9+Dwj+Fdum6I+SXQ7vxyeZCjFLcuq/aE/w/RTpIr0P0D6AKWyIaKwZ0S18qt 9Pdej8GAbDAHQTQlXerDVfa7iaUZF5xq4ExOTDxm7QU+8mNwfRzngrDPgvJZhc50= X-Gm-Gg: AR+sD10Vjfrds+JORriHJw9uIM77KOhj36P752ZOOiCwI/M7krriyfLBiCAwMWbYf6j WL9FsVkzMzgk1CJ4P/nQGj1RgJQXgGOW/tiZpwXjeRBT4YxsFNeaq4di4tOYC+UnnI8TNOLYx/Y hM5dikiy4ibYkkkzpfKMaqqYDk1EODmQ80rhNUfxdybUTrzr6soRgsDp7XCic+FPPoFx6+VpFW/ mb4Lwhlc78CImvWUNypfCRZ9xessQomfe8noNCFiwBel2BJgcV5IbLCV6XPdkosMyTJNxQ7NNyl AUYCA9L+D9hKg87eVPcMf8B8YblB4X04+cLbZexiF3BbJCXQV1dN7kwGtdQfPOcpQhdu3gJrSK9 IVvs+yPyoiAEX/1Ssrx2wfIGpnVnrQMp8T5rqVw== X-Received: by 2002:a17:903:b06:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2d74ce16d3bmr35880575ad.0.1787865109864; Thu, 27 Aug 2026 14:11:49 -0700 (PDT) X-Received: by 2002:a17:903:b06:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2d74ce16d3bmr35879605ad.0.1787865109415; Thu, 27 Aug 2026 14:11:49 -0700 (PDT) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3285f3cd3b0sm7758654eec.12.2026.08.27.14.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 14:11:48 -0700 (PDT) Date: Fri, 28 Aug 2026 02:41:41 +0530 From: Abhinaba Rakshit To: Kuldeep Singh Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Adrian Hunter , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neeraj Soni , Harshal Dev , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v12 1/6] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20260824-enable-ice-clock-scaling-v12-0-09271f583dc6@oss.qualcomm.com> <20260824-enable-ice-clock-scaling-v12-1-09271f583dc6@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI3MDE3OSBTYWx0ZWRfX5EnOZWkAq6fl hWI9UckYossGPvbggAH9gr9J8gp1xgzHbs0mFyu/baGHZQR1TBan/zMIzsalfPXVOI0bZTqZ7G5 eBKuCb10gtVIfy1i7sg72kEyr9s/tFaNZ5Hlt3sxIlWitK6p1a9A4ecEEHgdVbQEit1/s9N8eu0 kKVAe25C6aHCfpzLHTrvoytMdsPEycerazLjiXDKEgM/4/p1lzaLXSAhyN5WcZN9ZF29S/vuIze VArUiilshL5If5yJ43BeAmu7O++LR6yBkpbNS8/j2pkO/p1N4ErY/wMkO/b1XG8lNO4xF0B0UpD yqk9OABtFJamj4s0WQmLiYlwvsW1kMVcm196eqe1RqjSg66+V8z49L3Dj9zxeRmmMkWR8KWB9Nm LI+2L+slMFbFaAYAXFlBRQ4hfqy6D6wwp0Dhho9P1NT+d0IzR6JbltJw8sfBJXKyKnr4McetaZC rttxKo8iDvQ0rK9InFw== X-Authority-Analysis: v=2.4 cv=d5DFDxjE c=1 sm=1 tr=0 ts=6a90a816 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=AC2Mn6xCbOXL0dGbV_AA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: c9E21WbxMhjtZDg-o4C8y25grYvkwDjw X-Proofpoint-ORIG-GUID: c9E21WbxMhjtZDg-o4C8y25grYvkwDjw X-Proofpoint-Spam-Info: AW1haW4tMjYwODI3MDE3OSBTYWx0ZWRfX55Lxx+fmZPlC LJTBB3hJkRIWsPKXHkeU/qjfbgcLr4xKFpXR2Z7rUd8fpCLeRgcu0RQOwsQTcqBlEJRJsJgMCec cfJ0uJ278FLdsLIeC8eHVsES4lqHjxI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-27_08,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608270179 On Thu, Aug 27, 2026 at 12:17:02PM +0530, Kuldeep Singh wrote: > On 24-08-2026 01:17, Abhinaba Rakshit wrote: > > Register optional operation-points-v2 table for ICE device > > during device probe. Attach the OPP-table with only the ICE > > core clock. Since, dtbinding is on a transition phase to include > > iface clock and clock-names, attaching the opp-table to core clock > > remains optional such that it does not cause probe failures. > > iface clock and corresponding dtbindings are merged for v7.3 and your > change will land post that. > We can drop this from commit message? > > I think we should scale only core clock and for iface clock should rely > on ufs/eMMC controller maitained frequency. > The idea here is to scale only the core clock and I am achieving it by using dev_pm_opp_set_clkname() API. However, for that clock-names needs to be as required property under DT bindings for qcom ICE. As the comment mentioned here: https://lore.kernel.org/all/b32c7091-b2c4-443d-b58e-759b471f67db@oss.qualcomm.com/, the current dtbindings supports backward compatibility with iface being optional, hence it is expected that driver should be backward compatible as well. Once, we plan to break this backward compatibility and make iface clock and clock-names property as required, we can say its out of transitional phase. Abhinaba Rakshit