From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=194.117.254.33 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792663246; b=wNW6WgR5UFJ+FsHzIv118jgcPRt4hycK9s9ASy11+1S6lcWDYkl7Pv9VgXGdDSwbaU4d ldeLdDM+Dv0wnrl3TH1MyGyH2cLcAu/+xeFJQ81uUVH225J6qzdSm/IfaITIqdcYxbKt+ LrH0cj297bWebKoQRSXrzRdGhlHnDKgjndNnG60XxPsdJ7sWHibfYyfCifaKQ/cMtgjxx SU6YxqLKcib4kzQtG5/wnC+vizN/CeXMO9W5hboQzJTIybx8qnnA+1RvRulpahefhVG4x cRowycihY3K2rHeBQvFtWNZjWWC5SAkZIvcFgsp1IMGOmuazGGXLeuMLS/8q5a6gJUg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792663246; h=DMARC-Filter:DKIM-Signature:Received:Received:X-UD-Smtp-Session:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=idteAz0iY6oQGnUZPllHA4/u9rOX28sQjb77eJbpZRg=; b=CgCCnWMdluHfX+JvpNgvYxczkyJu/Wr2Vao1zXEAcR9gW0I9duA+svw7lEIip6C3ih23 bw6jqvPq3YJqEwTPCZxbkXJXIgk+RO7YoZUYKm6ujcU3RBat0cd9nwm19j+GnWHF0uwEZ OApUY4n9R8HdNpuQ+xiet9aQaAJIlvoyk0BVkqC2OyRdAcy8bnBLe/7YNDSpeqJKbEuf7 X1Qp0an9RN/vcsKnMDb8QvdbDjypBDWkgfTqq+ildaKKsyxXnpQSNrdM+aTdtCloIwWxn pIF6kYxifBtH0pkTQIORvl2oOsTjALPUjvp+P/5qerhWpSkk1I+WrwT01OMfLo02aQA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=Y3cztLW+; arc=none smtp.remote-ip=194.117.254.33 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F81606A31A for ; Thu, 22 Oct 2026 10:00:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E6F81606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=Y3cztLW+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=idte Az0iY6oQGnUZPllHA4/u9rOX28sQjb77eJbpZRg=; b=Y3cztLW+w0Qb5mx7TYBw EqXTv70aLz9olEPqhKB9Qyb5BV795IWAOyWh6QJ9K2fByKJBhQJhthsAdSVCl7gu Uur5VXMBu945130iIboMsfwWR0yAnvuIaeXUwE9jnfEtmHcMSpyu7OBxIHI5nW4r nz1iusqRxlD8cvrwy0pTXMoFTwY+ED9btUiwNP5iCwjE4dBFwZrOIfagR3Bu2slv 1KDsYTpY9VL7S7gW5EmS79HIEySAIEgUVWpLxMa8fnAG+lhABCMBf1KAwLJl5FPm znebT1RNMkWJ9ZRf454V6wfxgYbz+h69I/qrXMubPpD/lkV8S4QwQKhYq7aZmKUQ DA== Received: (qmail 1097692 invoked from network); 22 Oct 2026 12:00:43 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 22 Oct 2026 12:00:43 +0200 X-UD-Smtp-Session: l3s3148p1@WxDW72peKr4ujns/ Date: Thu, 22 Oct 2026 12:00:43 +0200 From: wsa+renesas To: Biju Das Cc: "biju.das.au" , Ulf Hansson , "linux-mmc@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Prabhakar Mahadev Lad Subject: Re: [PATCH v24 10/15] mmc: renesas_sdhi: Add write32_hook for CTL_SD_CARD_CLK_CTL register writes Message-ID: References: <20260820171657.62815-1-biju.das.jz@bp.renesas.com> <20260820171657.62815-11-biju.das.jz@bp.renesas.com> X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n6/6OV4/iym/jbxT" Content-Disposition: inline In-Reply-To: --n6/6OV4/iym/jbxT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > For safer side I will add, considering this code is used by other vendors > they may call sd_ctrl_write32() in future with no TMIO_MMC_HAS_IDLE_WAIT = flag. > Currently all Renesas SoCs have this flag set. >=20 > if (!(pdata->flags & TMIO_MMC_HAS_IDLE_WAIT)) { > _host->write16_hook =3D NULL; > _host->write32_hook =3D NULL; > } Yes, please. The consistency that comes with it is also helpful. --n6/6OV4/iym/jbxT Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmrZ3ssACgkQFA3kzBSg KbZnzg//XySm0/K7qg5+wtGqRVaQqewoUnFJySVykE+Dh/iOnDi5Yjc0QgYuWSDl G/IbJVXZrk72yt54MA65gECGEVSyRDN0+hr0glDz5aPkybA9QGyygGYIl+LiVfat oEsLJMY5/+HkBsJ0HVJ0n3Yl13JiLfYBwjyReEa4+wCSgFx661PGvjaPFx08riKp TNi32RovkCLS4CHjw2qucB1U2YNkbcaD3NZBeyZscETSPRq8W3+KglNAn95uRvfp FCB0Q1gPL0k86p7EyFcaQ63S2edObsWYPAkKcjs7aN/yLBla1fRiB0Md8xa+HJ4U /pBD/eAnUd7Pb62Ilw1S9rd3nxQdpLwXPvEfLnAyThk3K+8n5CElet70n99uGpxa MJRZtnIYQfxR69iVydftQHyIpgdoVIkYfz+B33wLrcOwlwBEOcCNkQEt+vNYeE0e hiFzVstT/Kt36Vc5yFgbB6k7O6flX5sHSTQ24TxNQw2FyerjYILIRl7CeWk4sn8P 87JId75IiXktPGGn8KF8MQYADyrBPKzqqoAQ7Bn3WDqjvuYbjEJS/i2zr8ccdAyA VWR4asFuaQ56S+KVSyqDe9ArGPn8w5SO4boElgchc5NJZ/q7U13QCbvhacXmlHIK 2YoKgHSfobybkWf0WWSb3c5GHEJ5JiA0JQ9IUB9H4xfsCPd1rBQ= =vL57 -----END PGP SIGNATURE----- --n6/6OV4/iym/jbxT--