public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>,
	michal.simek@xilinx.com, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h
Date: Fri, 21 Jul 2017 16:35:17 +0300	[thread overview]
Message-ID: <b1ce691e-c389-9ff6-fa36-4c1169623187@intel.com> (raw)
In-Reply-To: <20170717012332.16505-1-jeff.dagenais@gmail.com>

On 17/07/17 04:23, Jean-Francois Dagenais wrote:
> This increases consistency of the code across the sdhci family.
> 
> v2: rebased onto ulfh/mmc/next and tweaked headline accordingly.

As mentioned elsewhere, v2 comment doesn't belong in commit message.

> 
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index b13c0a7d50e4..528a5d24c0bc 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -216,13 +216,13 @@ static void sdhci_arasan_hs400_enhanced_strobe(struct mmc_host *mmc,
>  	u32 vendor;
>  	struct sdhci_host *host = mmc_priv(mmc);
>  
> -	vendor = readl(host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	vendor = sdhci_readl(host, SDHCI_ARASAN_VENDOR_REGISTER);
>  	if (ios->enhanced_strobe)
>  		vendor |= VENDOR_ENHANCED_STROBE;
>  	else
>  		vendor &= ~VENDOR_ENHANCED_STROBE;
>  
> -	writel(vendor, host->ioaddr + SDHCI_ARASAN_VENDOR_REGISTER);
> +	sdhci_writel(host, vendor, SDHCI_ARASAN_VENDOR_REGISTER);
>  }
>  
>  static void sdhci_arasan_reset(struct sdhci_host *host, u8 mask)
> 


  parent reply	other threads:[~2017-07-21 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  1:23 [PATCH] mmc: sdhci-of-arasan: use io functions from sdhci.h Jean-Francois Dagenais
2017-07-17  6:33 ` Michal Simek
2017-07-17 13:26   ` Jean-Francois Dagenais
2017-07-21 13:35 ` Adrian Hunter [this message]
2017-07-22 13:17 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1ce691e-c389-9ff6-fa36-4c1169623187@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=jeff.dagenais@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox