Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Sarthak Garg <quic_sartgarg@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>
Cc: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<quic_cang@quicinc.com>, <quic_nguyenb@quicinc.com>,
	<quic_rampraka@quicinc.com>, <quic_pragalla@quicinc.com>,
	<quic_sayalil@quicinc.com>, <quic_nitirawa@quicinc.com>,
	<quic_bhaskarv@quicinc.com>, <kernel@oss.qualcomm.com>
Subject: Re: [PATCH V4 2/4] dt-bindings: mmc: controller: Add max-sd-hs-frequency property
Date: Fri, 1 Aug 2025 16:11:29 +0530	[thread overview]
Message-ID: <b43cb2fd-c583-4383-9b2a-c186ac1c4e09@quicinc.com> (raw)
In-Reply-To: <98bd97cd-0d34-4bb6-869f-68feec1de68e@kernel.org>



On 8/1/2025 2:30 PM, Krzysztof Kozlowski wrote:
> On 01/08/2025 10:45, Sarthak Garg wrote:
>> Some platforms may require limiting the maximum frequency used in SD
>> High-Speed (HS) mode due to board-level hardware constraints. For
>> example, certain boards may include level shifters or other components
>> that cannot reliably operate at the default 50 MHz HS frequency.
>>
>> Introduce a new optional device tree property max-sd-hs-frequency to
>> limit the maximum frequency (in Hz) used for SD cards operating in
>> High-Speed (HS) mode.
>>
>> Signed-off-by: Sarthak Garg <quic_sartgarg@quicinc.com>
>> ---
>>   .../devicetree/bindings/mmc/mmc-controller-common.yaml | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
>> index 9a7235439759..6c2529b976d1 100644
>> --- a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
>> @@ -93,6 +93,16 @@ properties:
>>       minimum: 400000
>>       maximum: 384000000
>>   
>> +  max-sd-hs-frequency:
> 
> Use standard unit suffixes. s/frequency/hz/
> 
> 
> 

Sure will update this name to max-sd-hs-hz in V5.

>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: |
>> +      Maximum frequency (in Hz) to be used for SD cards operating in
>> +      High-Speed (HS) mode. This is useful for board-specific limitations,
>> +      such as level shifters or others where the card cannot reliably
>> +      operate at the default 50 MHz HS frequency.
> 
> Don't repeat constraints in free form text.
> 
> default:
> 
> 

Sure will remove min/max constraints and add default: 50000000 in V5.

  reply	other threads:[~2025-08-01 10:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01  8:45 [PATCH V4 0/4] Add level shifter support for qualcomm SOC's Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 1/4] mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 2/4] dt-bindings: mmc: controller: Add max-sd-hs-frequency property Sarthak Garg
2025-08-01  9:00   ` Krzysztof Kozlowski
2025-08-01 10:41     ` Sarthak Garg [this message]
2025-08-01  8:45 ` [PATCH V4 3/4] mmc: core: Introduce a new flag max-sd-hs-frequency Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 4/4] arm64: dts: qcom: sm8550: Remove SDR104/SDR50 broken capabilities Sarthak Garg
2025-08-01  9:02   ` Krzysztof Kozlowski
2025-08-05  9:19     ` Sarthak Garg
2025-08-05  9:25       ` Krzysztof Kozlowski
2025-08-13 11:08         ` Sarthak Garg
2025-08-13 11:21           ` Konrad Dybcio
2025-08-13 11:56             ` Krzysztof Kozlowski
2025-08-13 12:07               ` Konrad Dybcio
2025-08-14  7:15                 ` Sarthak Garg
2025-08-19 13:30                   ` Neil Armstrong
2025-08-20  7:19                     ` Sarthak Garg
2025-08-05  9:59       ` Dmitry Baryshkov
2025-08-05 13:08         ` Konrad Dybcio
2025-08-13 11:20           ` Sarthak Garg
2025-08-13 11:14         ` Sarthak Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b43cb2fd-c583-4383-9b2a-c186ac1c4e09@quicinc.com \
    --to=quic_sartgarg@quicinc.com \
    --cc=adrian.hunter@intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=quic_bhaskarv@quicinc.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_pragalla@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    --cc=quic_sayalil@quicinc.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox