From: Adrian Hunter <adrian.hunter@intel.com>
To: LinuxPatchCommit <LinuxPatchCommit@bayhubtech.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Shirley Her (SC)" <shirley.her@bayhubtech.com>
Subject: Re: [PATCH 2/3] mmc: sdhci-pci-o2micro: Add eMMC HS200 support
Date: Tue, 19 Dec 2017 10:02:46 +0200 [thread overview]
Message-ID: <b5fa6218-906a-0dc6-810b-372b41f76907@intel.com> (raw)
In-Reply-To: <CY4PR04MB047374AC40568EF03031F49CED3C0@CY4PR04MB0473.namprd04.prod.outlook.com>
On 04/12/17 12:10, LinuxPatchCommit wrote:
> Dear all,
A greeting is not needed in a commit message.
>
> Add register definition for eMMC HS200 mode.
> Add hardware tuning for eMMC HS200 mode.
>
> Signed-off-by: ernest.zhang <ernest.zhang@bayhubtech.com>
> ---
> drivers/mmc/host/sdhci-pci-o2micro.h | 3 +++
sdhci-pci-o2micro.h was removed by commit 361eeda0ca16 ("mmc: sdhci-pci:
Tidy o2micro definitions"). Please re-base.
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.h b/drivers/mmc/host/sdhci-pci-o2micro.h
> index 770f53857211..3fb957729315 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.h
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.h
> @@ -49,6 +49,7 @@
> #define O2_SD_MISC_CTRL4 0xFC
> #define O2_SD_TUNING_CTRL 0x300
> #define O2_SD_PLL_SETTING 0x304
> +#define O2_SD_MISC_SETTING 0x308
> #define O2_SD_CLK_SETTING 0x328
> #define O2_SD_CAP_REG2 0x330
> #define O2_SD_CAP_REG0 0x334
> @@ -62,6 +63,8 @@
> #define O2_SD_FREG4_ENABLE_CLK_SET BIT(22)
>
> #define O2_SD_VENDOR_SETTING 0x110
> +#define O2_SD_HW_TUNING_ENABLE BIT(4)
Both these definitions are needed in patch 1. It would be better to add
them in that patch.
> +
> #define O2_SD_VENDOR_SETTING2 0x1C8
>
> extern int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot);
>
prev parent reply other threads:[~2017-12-19 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 10:10 [PATCH 2/3] mmc: sdhci-pci-o2micro: Add eMMC HS200 support LinuxPatchCommit
2017-12-19 8:02 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5fa6218-906a-0dc6-810b-372b41f76907@intel.com \
--to=adrian.hunter@intel.com \
--cc=LinuxPatchCommit@bayhubtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shirley.her@bayhubtech.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox