From: Dmitry Osipenko <digetx@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties
Date: Tue, 19 May 2020 17:05:27 +0300 [thread overview]
Message-ID: <b634e7a5-9a30-3bd1-126d-be62e4dd73e1@gmail.com> (raw)
In-Reply-To: <CAPDyKFo_Xp-zipqE26iMv4CFwUoMCQZy3Zr63Cp=uzePgWX7BA@mail.gmail.com>
19.05.2020 10:28, Ulf Hansson пишет:
> On Sat, 16 May 2020 at 17:44, Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> Several people asked me about the MMC warnings in the KMSG log and
>> I had to tell to ignore them because these warning are irrelevant to
>> pre-Tegra210 SoCs.
>
> Why are the warnings irrelevant?
That's what the DT binding doc says [1].
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/mmc/nvidia%2Ctegra20-sdhci.txt
Although, looking at the driver's code and TRM docs, it seems that all
those properties are really irrelevant only to the older Terga20 SoC. So
the binding doc is a bit misleading.
Nevertheless, the binding explicitly says that the properties are
optional, which is correct.
>> It should be up to a board's device-tree writer to
>> properly describe all the necessary properties. Secondly, eventually all
>> device-tree bindings will be converted to YAML, which allows to validate
>> board DT files, giving a warning about missing properties. Hence let's
>> remove the noisy warnings to stop the confusion.
>
> Yep, makes sense. However, perhaps we should do this conversion then,
> rather than first drop the warnings?
I don't mind to postpone this patch. But again, IIUC, all these
properties are optional, and thus, there is no critical need to verify
them in DT right now, it could be done later on.
next prev parent reply other threads:[~2020-05-19 14:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 15:43 [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties Dmitry Osipenko
2020-05-19 7:28 ` Ulf Hansson
2020-05-19 14:05 ` Dmitry Osipenko [this message]
2020-05-19 15:29 ` Ulf Hansson
2020-05-19 16:24 ` Thierry Reding
2020-05-19 16:33 ` Dmitry Osipenko
2020-05-19 18:34 ` Sowjanya Komatineni
2020-05-19 18:41 ` Sowjanya Komatineni
2020-05-19 19:07 ` Sowjanya Komatineni
2020-05-19 20:44 ` Sowjanya Komatineni
2020-05-20 2:00 ` Dmitry Osipenko
2020-05-20 11:26 ` Ulf Hansson
2020-05-20 16:09 ` Sowjanya Komatineni
2020-05-22 12:13 ` Thierry Reding
2020-05-22 12:18 ` Dmitry Osipenko
2020-05-22 12:34 ` Thierry Reding
2020-05-22 15:22 ` Sowjanya Komatineni
2020-05-22 15:26 ` Thierry Reding
2020-05-22 15:57 ` Sowjanya Komatineni
2020-05-25 8:47 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b634e7a5-9a30-3bd1-126d-be62e4dd73e1@gmail.com \
--to=digetx@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox