linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema
@ 2025-10-23 17:37 Charan Pedumuru
  2025-10-27 13:57 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Charan Pedumuru @ 2025-10-23 17:37 UTC (permalink / raw)
  To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Taichi Sugaya, Takao Orito
  Cc: linux-mmc, devicetree, linux-arm-kernel, linux-kernel,
	Charan Pedumuru

Convert SOCIONEXT Milbeaut SDHCI controller binding to YAML format.
Add a new property "voltage-ranges" to resolve dt_check errors.

Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
 .../devicetree/bindings/mmc/sdhci-milbeaut.txt     | 30 ---------
 .../mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml     | 78 ++++++++++++++++++++++
 2 files changed, 78 insertions(+), 30 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
deleted file mode 100644
index 627ee89c125b..000000000000
--- a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-* SOCIONEXT Milbeaut SDHCI controller
-
-This file documents differences between the core properties in mmc.txt
-and the properties used by the sdhci_milbeaut driver.
-
-Required properties:
-- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
-- clocks: Must contain an entry for each entry in clock-names. It is a
-  list of phandles and clock-specifier pairs.
-  See ../clocks/clock-bindings.txt for details.
-- clock-names: Should contain the following two entries:
-	"iface" - clock used for sdhci interface
-	"core"  - core clock for sdhci controller
-
-Optional properties:
-- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
-  requires the CMD_DAT_DELAY control to be enabled.
-
-Example:
-	sdhci3: mmc@1b010000 {
-		compatible = "socionext,milbeaut-m10v-sdhci-3.0";
-		reg = <0x1b010000 0x10000>;
-		interrupts = <0 265 0x4>;
-		voltage-ranges = <3300 3300>;
-		bus-width = <4>;
-		clocks = <&clk 7>, <&ahb_clk>;
-		clock-names = "core", "iface";
-		cap-sdio-irq;
-		fujitsu,cmd-dat-delay-select;
-	};
diff --git a/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
new file mode 100644
index 000000000000..6b67bef30347
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SOCIONEXT Milbeaut SDHCI controller
+
+maintainers:
+  - Taichi Sugaya <sugaya.taichi@socionext.com>
+  - Takao Orito <orito.takao@socionext.com>
+
+description:
+  The SOCIONEXT Milbeaut SDHCI controller is a specialized SD Host
+  Controller found in some of Socionext's Milbeaut image processing SoCs.
+  It features a dedicated "bridge controller." This bridge controller
+  implements special functions like reset control, clock management for
+  various SDR modes (SDR12, SDR25, SDR50) and physical pin property settings.
+
+allOf:
+  - $ref: sdhci-common.yaml#
+
+properties:
+  compatible:
+    const: socionext,milbeaut-m10v-sdhci-3.0
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: core
+      - const: iface
+
+  fujitsu,cmd-dat-delay-select:
+    description:
+      Its presence indicates that the controller requires a specific command
+      and data line delay selection mechanism for proper operation, particularly
+      when dealing with high-speed SD/eMMC modes.
+    type: boolean
+
+  voltage-ranges:
+    $ref: /schemas/types.yaml#/definitions/uint32-matrix
+    description:
+      Two cells are required, first cell specifies minimum slot voltage (mV),
+      second cell specifies maximum slot voltage (mV).
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    mmc@1b010000 {
+        compatible = "socionext,milbeaut-m10v-sdhci-3.0";
+        reg = <0x1b010000 0x10000>;
+        interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
+        voltage-ranges = <3300 3300>;
+        bus-width = <4>;
+        clocks = <&clk 7>, <&ahb_clk>;
+        clock-names = "core", "iface";
+        cap-sdio-irq;
+        fujitsu,cmd-dat-delay-select;
+    };
+...

---
base-commit: 7bac2c97af4078d7a627500c9bcdd5b033f97718
change-id: 20250524-milbeaut-5c0267202e2c

Best regards,
-- 
Charan Pedumuru <charan.pedumuru@gmail.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema
  2025-10-23 17:37 [PATCH] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema Charan Pedumuru
@ 2025-10-27 13:57 ` Rob Herring
  2025-10-27 14:11   ` Charan Pedumuru
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2025-10-27 13:57 UTC (permalink / raw)
  To: Charan Pedumuru
  Cc: Ulf Hansson, Krzysztof Kozlowski, Conor Dooley, Taichi Sugaya,
	Takao Orito, linux-mmc, devicetree, linux-arm-kernel,
	linux-kernel

On Thu, Oct 23, 2025 at 05:37:36PM +0000, Charan Pedumuru wrote:
> Convert SOCIONEXT Milbeaut SDHCI controller binding to YAML format.
> Add a new property "voltage-ranges" to resolve dt_check errors.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
>  .../devicetree/bindings/mmc/sdhci-milbeaut.txt     | 30 ---------
>  .../mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml     | 78 ++++++++++++++++++++++
>  2 files changed, 78 insertions(+), 30 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> deleted file mode 100644
> index 627ee89c125b..000000000000
> --- a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -* SOCIONEXT Milbeaut SDHCI controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci_milbeaut driver.
> -
> -Required properties:
> -- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
> -- clocks: Must contain an entry for each entry in clock-names. It is a
> -  list of phandles and clock-specifier pairs.
> -  See ../clocks/clock-bindings.txt for details.
> -- clock-names: Should contain the following two entries:
> -	"iface" - clock used for sdhci interface
> -	"core"  - core clock for sdhci controller
> -
> -Optional properties:
> -- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
> -  requires the CMD_DAT_DELAY control to be enabled.
> -
> -Example:
> -	sdhci3: mmc@1b010000 {
> -		compatible = "socionext,milbeaut-m10v-sdhci-3.0";
> -		reg = <0x1b010000 0x10000>;
> -		interrupts = <0 265 0x4>;
> -		voltage-ranges = <3300 3300>;
> -		bus-width = <4>;
> -		clocks = <&clk 7>, <&ahb_clk>;
> -		clock-names = "core", "iface";
> -		cap-sdio-irq;
> -		fujitsu,cmd-dat-delay-select;
> -	};
> diff --git a/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
> new file mode 100644
> index 000000000000..6b67bef30347
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SOCIONEXT Milbeaut SDHCI controller
> +
> +maintainers:
> +  - Taichi Sugaya <sugaya.taichi@socionext.com>
> +  - Takao Orito <orito.takao@socionext.com>
> +
> +description:
> +  The SOCIONEXT Milbeaut SDHCI controller is a specialized SD Host
> +  Controller found in some of Socionext's Milbeaut image processing SoCs.
> +  It features a dedicated "bridge controller." This bridge controller
> +  implements special functions like reset control, clock management for
> +  various SDR modes (SDR12, SDR25, SDR50) and physical pin property settings.
> +
> +allOf:
> +  - $ref: sdhci-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: socionext,milbeaut-m10v-sdhci-3.0
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: core
> +      - const: iface
> +
> +  fujitsu,cmd-dat-delay-select:
> +    description:
> +      Its presence indicates that the controller requires a specific command
> +      and data line delay selection mechanism for proper operation, particularly
> +      when dealing with high-speed SD/eMMC modes.
> +    type: boolean
> +
> +  voltage-ranges:
> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix

Sounds more like a uint32-array.

> +    description:
> +      Two cells are required, first cell specifies minimum slot voltage (mV),
> +      second cell specifies maximum slot voltage (mV).
> +    maxItems: 1

You can better describe it like this:

items:
  - description: minimum slot voltage (mV)
  - description: maximum slot voltage (mV)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema
  2025-10-27 13:57 ` Rob Herring
@ 2025-10-27 14:11   ` Charan Pedumuru
  0 siblings, 0 replies; 3+ messages in thread
From: Charan Pedumuru @ 2025-10-27 14:11 UTC (permalink / raw)
  To: Rob Herring
  Cc: Ulf Hansson, Krzysztof Kozlowski, Conor Dooley, Taichi Sugaya,
	Takao Orito, linux-mmc, devicetree, linux-arm-kernel,
	linux-kernel



On 27-10-2025 19:27, Rob Herring wrote:
> On Thu, Oct 23, 2025 at 05:37:36PM +0000, Charan Pedumuru wrote:
>> Convert SOCIONEXT Milbeaut SDHCI controller binding to YAML format.
>> Add a new property "voltage-ranges" to resolve dt_check errors.
>>
>> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
>> ---
>>  .../devicetree/bindings/mmc/sdhci-milbeaut.txt     | 30 ---------
>>  .../mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml     | 78 ++++++++++++++++++++++
>>  2 files changed, 78 insertions(+), 30 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt b/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
>> deleted file mode 100644
>> index 627ee89c125b..000000000000
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-milbeaut.txt
>> +++ /dev/null
>> @@ -1,30 +0,0 @@
>> -* SOCIONEXT Milbeaut SDHCI controller
>> -
>> -This file documents differences between the core properties in mmc.txt
>> -and the properties used by the sdhci_milbeaut driver.
>> -
>> -Required properties:
>> -- compatible: "socionext,milbeaut-m10v-sdhci-3.0"
>> -- clocks: Must contain an entry for each entry in clock-names. It is a
>> -  list of phandles and clock-specifier pairs.
>> -  See ../clocks/clock-bindings.txt for details.
>> -- clock-names: Should contain the following two entries:
>> -	"iface" - clock used for sdhci interface
>> -	"core"  - core clock for sdhci controller
>> -
>> -Optional properties:
>> -- fujitsu,cmd-dat-delay-select: boolean property indicating that this host
>> -  requires the CMD_DAT_DELAY control to be enabled.
>> -
>> -Example:
>> -	sdhci3: mmc@1b010000 {
>> -		compatible = "socionext,milbeaut-m10v-sdhci-3.0";
>> -		reg = <0x1b010000 0x10000>;
>> -		interrupts = <0 265 0x4>;
>> -		voltage-ranges = <3300 3300>;
>> -		bus-width = <4>;
>> -		clocks = <&clk 7>, <&ahb_clk>;
>> -		clock-names = "core", "iface";
>> -		cap-sdio-irq;
>> -		fujitsu,cmd-dat-delay-select;
>> -	};
>> diff --git a/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
>> new file mode 100644
>> index 000000000000..6b67bef30347
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml
>> @@ -0,0 +1,78 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mmc/socionext,milbeaut-m10v-sdhci-3.0.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: SOCIONEXT Milbeaut SDHCI controller
>> +
>> +maintainers:
>> +  - Taichi Sugaya <sugaya.taichi@socionext.com>
>> +  - Takao Orito <orito.takao@socionext.com>
>> +
>> +description:
>> +  The SOCIONEXT Milbeaut SDHCI controller is a specialized SD Host
>> +  Controller found in some of Socionext's Milbeaut image processing SoCs.
>> +  It features a dedicated "bridge controller." This bridge controller
>> +  implements special functions like reset control, clock management for
>> +  various SDR modes (SDR12, SDR25, SDR50) and physical pin property settings.
>> +
>> +allOf:
>> +  - $ref: sdhci-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: socionext,milbeaut-m10v-sdhci-3.0
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 2
>> +
>> +  clock-names:
>> +    items:
>> +      - const: core
>> +      - const: iface
>> +
>> +  fujitsu,cmd-dat-delay-select:
>> +    description:
>> +      Its presence indicates that the controller requires a specific command
>> +      and data line delay selection mechanism for proper operation, particularly
>> +      when dealing with high-speed SD/eMMC modes.
>> +    type: boolean
>> +
>> +  voltage-ranges:
>> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> 
> Sounds more like a uint32-array.

Okay, I will change that.

> 
>> +    description:
>> +      Two cells are required, first cell specifies minimum slot voltage (mV),
>> +      second cell specifies maximum slot voltage (mV).
>> +    maxItems: 1
> 
> You can better describe it like this:
> 
> items:
>   - description: minimum slot voltage (mV)
>   - description: maximum slot voltage (mV)

Sure.

-- 
Best Regards,
Charan.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-27 14:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-23 17:37 [PATCH] dt-bindings: mmc: socionext,milbeaut-m10v-sdhci-3.0: convert to DT schema Charan Pedumuru
2025-10-27 13:57 ` Rob Herring
2025-10-27 14:11   ` Charan Pedumuru

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).