From: Markus Elfring <Markus.Elfring@web.de>
To: Avri Altman <Avri.Altman@sandisk.com>, linux-mmc@vger.kernel.org
Cc: Avri Altman <avri.altman@wdc.com>, Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: mmc-utils: Completion of error handling
Date: Thu, 26 Jun 2025 12:10:20 +0200 [thread overview]
Message-ID: <b68f945f-7f86-4f8c-9fac-5b115a83d3c6@web.de> (raw)
In-Reply-To: <PH7PR16MB619651DAF605B93FE8E839A7E57AA@PH7PR16MB6196.namprd16.prod.outlook.com>
>> I have taken also another look at implementation details.
> Also? I am lacking some context here.
I am just another code reviewer here.
>> Thus I have noticed that the error detection is incomplete so far.
Various source code analysis tools can point remaining open issues out.
>> How do you think about to add more error handling for return values from
>> functions like printf() (for example)?
>> https://git.kernel.org/pub/scm/utils/mmc/mmc-
>> utils.git/tree/mmc.c?h=v1.0#n515
> You are most welcome to send your patches over.
Several software design options can be clarified accordingly.
> We can discuss your ideas over the code.
How will chances evolve to benefit any more also from the means of
aspect-oriented software development?
https://en.wikipedia.org/wiki/Aspect-oriented_programming
Regards,
Markus
prev parent reply other threads:[~2025-06-26 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 14:28 mmc-utils: Completion of error handling Markus Elfring
2025-06-26 7:03 ` Avri Altman
2025-06-26 10:10 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b68f945f-7f86-4f8c-9fac-5b115a83d3c6@web.de \
--to=markus.elfring@web.de \
--cc=Avri.Altman@sandisk.com \
--cc=avri.altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox