From: Ricky WU <ricky_wu@realtek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Gavin Li <gfl3162@gmail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Gavin Li <git@thegavinli.com>
Subject: RE: [PATCH v1] mmc: rtsx_usb_sdmmc: add parameter to always poll for card presence
Date: Wed, 28 May 2025 03:10:38 +0000 [thread overview]
Message-ID: <b843b011bebd4dc18f9b9da290958ded@realtek.com> (raw)
In-Reply-To: <CAPDyKFrXnVkOatAF_adg67LxfU7YOqeR_49_u2mOQLntQcCBfg@mail.gmail.com>
> On Sat, 24 May 2025 at 05:37, Gavin Li <gfl3162@gmail.com> wrote:
> >
> > On Mon, May 19, 2025 at 7:50 AM Ulf Hansson <ulf.hansson@linaro.org>
> wrote:
> >
> > > Moving this problem to userspace seems wrong to me. We should be
> > > able to do the right thing in the kernel.
> >
> > Unfortunately, I don't have access to the datasheet for the RTS5179 or
> > related chips. This is what I could do to get my own hardware working,
> > and it doesn't make sense to revert to polling mode for all users if
> > the interrupt mode detection works and reduces power consumption.
>
> Agree!
>
> >
> > > We should be able to detect if we are running the broken HW and in
> > > that case, set the flag based on that, right?
> >
> > I don't know of a way to do so, especially since I don't have
> > non-broken HW in my possession. On my hardware, once the device enters
> > autosuspend, inserting a card does not trigger a wakeup. I'm hoping
> > that there's a way to detect the broken HW via a hardware revision register
> or something similar.
>
> Yes, something along those lines would make sense. Let's see if Ricky can
> advise us on how to move forward.
>
Hi Gavin,
I’m not entirely clear on what the actual issue is at this point. Initially, there was mention of “some RTS5179…” and later,
“broken hardware…” was brought up.
Could you please clarify — is this problem happening only on certain platforms? Or is it something else?
HI Uif,
Is it generally true? That devices using the MMC_CAP_NEEDS_POLL flag may not fully support runtime_suspend,
Since they rely on polling rather than interrupts.
This can prevent the decices or host controller from reaching deeper power-saving states.
> Kind regards
> Uffe
next prev parent reply other threads:[~2025-05-28 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 3:19 [PATCH v1] mmc: rtsx_usb_sdmmc: add parameter to always poll for card presence Gavin Li
2025-05-19 11:50 ` Ulf Hansson
2025-05-24 3:36 ` Gavin Li
2025-05-27 14:22 ` Ulf Hansson
2025-05-28 3:10 ` Ricky WU [this message]
2025-07-21 2:31 ` Gavin Li
2025-07-21 6:13 ` Ricky WU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b843b011bebd4dc18f9b9da290958ded@realtek.com \
--to=ricky_wu@realtek.com \
--cc=gfl3162@gmail.com \
--cc=git@thegavinli.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox