From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jun Nie <jun.nie@linaro.org>,
shawn.guo@linaro.org, xie.baoyou@zte.com.cn
Cc: ulf.hansson@linaro.org, jason.liu@linaro.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 4/5] mmc: dw: Add fifo address property
Date: Fri, 28 Oct 2016 14:24:40 +0900 [thread overview]
Message-ID: <bc49c0a3-5159-03a2-0023-e32f2dbbf956@samsung.com> (raw)
In-Reply-To: <1477622229-32060-5-git-send-email-jun.nie@linaro.org>
On 10/28/2016 11:37 AM, Jun Nie wrote:
> The FIFO address may break default address assumption of 0x100
> (version < 0x240A) and 0x200(version >= 0x240A) in current driver.
> The new property is introduced to override fifo address via DT
> node information.
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
> drivers/mmc/host/dw_mmc.c | 5 +++++
> include/linux/mmc/dw_mmc.h | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1c9ee36..24ae05b6 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2955,6 +2955,8 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>
> of_property_read_u32(np, "card-detect-delay", &pdata->detect_delay_ms);
>
> + of_property_read_u32(np, "fifo-addr", &host->fifo_addr_override);
> +
> if (!of_property_read_u32(np, "clock-frequency", &clock_frequency))
> pdata->bus_hz = clock_frequency;
>
> @@ -3163,6 +3165,9 @@ int dw_mci_probe(struct dw_mci *host)
> else
> host->fifo_reg = host->regs + DATA_240A_OFFSET;
>
> + if (host->fifo_addr_override)
> + host->fifo_reg = host->regs + host->fifo_addr_override;
> +
Check condition the sequentially.
if (host->fifo_addr_override) {
...
} else if (host->verid < DW_MMC_240A) {
..
} else {
..
}
how about?
> tasklet_init(&host->tasklet, dw_mci_tasklet_func, (unsigned long)host);
> ret = devm_request_irq(host->dev, host->irq, dw_mci_interrupt,
> host->irq_flags, "dw-mci", host);
> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
> index f5af2bd..4866ef5 100644
> --- a/include/linux/mmc/dw_mmc.h
> +++ b/include/linux/mmc/dw_mmc.h
> @@ -107,6 +107,7 @@ struct dw_mci_dma_slave {
> * @ciu_clk: Pointer to card interface unit clock instance.
> * @slot: Slots sharing this MMC controller.
> * @fifo_depth: depth of FIFO.
> + * @fifo_addr_override: override fifo reg offset with this value.
DATA addr is more correct. it's related with DATA register.
Best Regards,
Jaehoon Chung
> * @data_shift: log2 of FIFO item size.
> * @part_buf_start: Start index in part_buf.
> * @part_buf_count: Bytes of partial data in part_buf.
> @@ -154,6 +155,7 @@ struct dw_mci {
> spinlock_t irq_lock;
> void __iomem *regs;
> void __iomem *fifo_reg;
> + u32 fifo_addr_override;
>
> struct scatterlist *sg;
> struct sg_mapping_iter sg_miter;
>
next prev parent reply other threads:[~2016-10-28 5:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 2:37 [PATCH v2 0/5] Add intial support to DW MMC host on ZTE SoC Jun Nie
2016-10-28 2:37 ` [PATCH v2 1/5] mmc: dt-bindings: add ZTE MMC bindings Jun Nie
2016-10-28 2:37 ` [PATCH v2 2/5] mmc: zx: Initial support for ZX mmc controller Jun Nie
2016-10-28 5:16 ` Jaehoon Chung
2016-10-31 8:47 ` Jun Nie
2016-10-31 9:40 ` Jaehoon Chung
2016-11-01 1:16 ` Jun Nie
2016-11-01 7:25 ` Jaehoon Chung
2016-11-01 7:45 ` Jun Nie
2016-10-28 12:00 ` kbuild test robot
2016-10-28 2:37 ` [PATCH v2 3/5] Documentation: synopsys-dw-mshc: add binding for fifo quirks Jun Nie
2016-10-28 2:37 ` [PATCH v2 4/5] mmc: dw: Add fifo address property Jun Nie
2016-10-28 5:24 ` Jaehoon Chung [this message]
2016-10-31 8:50 ` Jun Nie
2016-10-31 9:35 ` Jaehoon Chung
2016-10-28 2:37 ` [PATCH v2 5/5] mmc: dw: Add fifo watermark quirk Jun Nie
2016-10-28 5:30 ` Jaehoon Chung
2016-10-31 8:48 ` Jun Nie
2016-10-31 9:35 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc49c0a3-5159-03a2-0023-e32f2dbbf956@samsung.com \
--to=jh80.chung@samsung.com \
--cc=jason.liu@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox