From: Adrian Hunter <adrian.hunter@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Piotr Sroka <piotrs@cadence.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support
Date: Tue, 15 Aug 2017 09:46:38 +0300 [thread overview]
Message-ID: <bfa3213f-8322-ca9c-8170-122f268f3ce3@intel.com> (raw)
In-Reply-To: <CAK7LNAQ344PnS9e21E8yzhorKxKjH74P5Znkewz3c39gc1zBVg@mail.gmail.com>
On 14/08/17 18:28, Masahiro Yamada wrote:
> Hi Adrian,
>
>
> 2017-08-14 19:53 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
>
>>> @@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>>> return ret;
>>> }
>>>
>>> +static int __maybe_unused sdhci_cdns_resume(struct device *dev)
>>
>> We don't use __maybe_unused in this case, we use #ifdef CONFIG_PM_SLEEP
>
>
> Could you tell me the reason
> why #ifdef CONFIG_PM_SLEEP is preferable?
>
> I see lots of __maybe_unused for suspend/resume hooks in drivers.
Not in sdhci drivers. It is easier for the maintainer to have consistency
across the code they maintain.
prev parent reply other threads:[~2017-08-15 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 1:44 [PATCH v2 0/4] mmc: sdhci: refactor PM in sdhci-pltfm add support PM for cadence port Masahiro Yamada
2017-08-03 1:44 ` [PATCH v2 1/4] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume Masahiro Yamada
2017-08-14 10:28 ` Adrian Hunter
2017-08-14 10:28 ` Adrian Hunter
2017-08-03 1:44 ` [PATCH v2 2/4] mmc: sdhci: remove #indef CONFIG_PM around function declarations Masahiro Yamada
2017-08-14 10:29 ` Adrian Hunter
2017-08-03 1:44 ` [PATCH v2 3/4] mmc: sdhci-pltfm: export sdhci_pltfm_suspend/resume Masahiro Yamada
2017-08-03 1:44 ` [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada
2017-08-14 10:53 ` Adrian Hunter
2017-08-14 15:28 ` Masahiro Yamada
2017-08-15 6:46 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa3213f-8322-ca9c-8170-122f268f3ce3@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=piotrs@cadence.com \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox