Re: [PATCH v3 2/9] dt-bindings: mmc: amlogic: Add compatible for T7 mmc

Ronald Claveau
2026-03-25T08:45:39Z

On 3/25/26 3:38 AM, Xianwei Zhao wrote:
> Hi Ronald,
>
> On 2026/3/23 17:55, Ronald Claveau wrote:
>> Add amlogic,t7-mmc compatible string, falling back to amlogic,meson-
>> axg-mmc
>> as the T7 MMC controller is compatible with the AXG implementation.
>>
>> Signed-off-by: Ronald Claveau<linux-kernel-dev@aliel.fr>
>> ---
>>   Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 5
>> ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> index 57646575a13f8..40dccf9715781 100644
>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> @@ -19,7 +19,10 @@ allOf:
>>   properties:
>>     compatible:
>>       oneOf:
>> -      - const: amlogic,meson-axg-mmc
>> +      - items:
>> +          - enum:
>> +              - amlogic,t7-mmc
>> +          - const: amlogic,meson-axg-mmc
>
> It seems that break API here.
> One item should be added here instead of being replaced.
>

Thanks Xianwei, ok I will change that in a new version.

>>         - items:
>>             - const: amlogic,meson-gx-mmc
>>             - const: amlogic,meson-gxbb-mmc
>>
>> --
>> 2.49.0

--
Best regards,
Ronald