Re: [PATCH v2 4/4] mmc: sdhci-pltfm: remove duplicate DTS property parsing

Adrian Hunter
2026-03-11T09:08:29Z

On 03/03/2026 12:50, ziniu.wang_1@nxp.com wrote:
> From: Luke Wang <ziniu.wang_1@nxp.com>
>
> The "keep-power-in-suspend", "wakeup-source" and "enable-sdio-wakeup"
> properties are already parsed in mmc_of_parse(). All sdhci drivers that
> call sdhci_get_property() also call mmc_of_parse(). The only exception
> is sdhci-of-hlwd, which does not call mmc_of_parse(), but its devicetree
> does not use these properties anyway.
>
> Signed-off-by: Luke Wang <ziniu.wang_1@nxp.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> drivers/mmc/host/sdhci-pltfm.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index d4fb60c1ef69..933fafe0a0ef 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -95,13 +95,6 @@ void sdhci_get_property(struct platform_device *pdev)
> sdhci_get_compatibility(pdev);
>
> device_property_read_u32(dev, "clock-frequency", &pltfm_host->clock);
> -
> - if (device_property_present(dev, "keep-power-in-suspend"))
> - host->mmc->pm_caps |= MMC_PM_KEEP_POWER;
> -
> - if (device_property_read_bool(dev, "wakeup-source") ||
> - device_property_read_bool(dev, "enable-sdio-wakeup")) /* legacy */
> - host->mmc->pm_caps |= MMC_PM_WAKE_SDIO_IRQ;
> }
> EXPORT_SYMBOL_GPL(sdhci_get_property);
>