From: Christian Loehle <CLoehle@hyperstone.com>
To: Avri Altman <Avri.Altman@wdc.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
Linux MMC List <linux-mmc@vger.kernel.org>
Subject: RE: [PATCH] mmc-utils: Add softreset command for issuing CMD0
Date: Tue, 19 Jul 2022 08:07:15 +0000 [thread overview]
Message-ID: <ca03eef23ff5419692b7e15c2f038640@hyperstone.com> (raw)
In-Reply-To: <DM6PR04MB6575A42E7EFD93C235BD5AA7FC8C9@DM6PR04MB6575.namprd04.prod.outlook.com>
>> CMD0 may be used to see if the hardware can handle a UHS card
>> that completed the voltage switch. If a UHS card has problems
>> coming back up after CMD0 your hardware may not support a hard
>> reset properly.
>I think it's a useful addition, not just for that reason.
>Specifically to test hw-reset support, I think you should use the GO_PRE_IDLE_STATE option.
Makes sense to add both, I can do that.
>
>> +
>> + memset(&idata, 0, sizeof(idata));
>> + idata.opcode = MMC_GO_IDLE_STATE;
>> + idata.flags = MMC_RSP_NONE | MMC_CMD_BC;
>How about adding all 3 flavors of soft-reset: GO_IDLE_STATE, GO_PRE_IDLE_STATE, and BOOT_INITIATION.
>There can be 3 different command, that calls the same __soft_reset helper, or whatever.
>What do you think?
I'm fine with GO_IDLE_STATE and GO_PRE_IDLE_STATE, but BOOT_INITATION Im not sure about, what purpose would it serve?
If the intention is to be able to get the boot operation done with multi_cmd of GO_PRE_IDLE_STATE and BOOT_INITATION and return the data then that would at least be some more testing effort before I resend.
I have only done the boot operations completely in the driver so far.
Furthermore I think many (most?) host controllers (or our drivers) seem to have issues with the transfer size I'd expect of a normal boot operation (i.e 4-32MB).
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
next prev parent reply other threads:[~2022-07-19 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 12:17 [PATCH] mmc-utils: Add softreset command for issuing CMD0 Christian Loehle
2022-07-18 12:24 ` Avri Altman
2022-07-19 8:07 ` Christian Loehle [this message]
2022-07-19 8:42 ` Avri Altman
-- strict thread matches above, loose matches on Subject: below --
2022-07-15 16:55 Christian Loehle
2022-07-18 11:21 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca03eef23ff5419692b7e15c2f038640@hyperstone.com \
--to=cloehle@hyperstone.com \
--cc=Avri.Altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox