From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D096356755 for ; Thu, 10 Sep 2026 07:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789024397; cv=none; b=nOIv9QdPZLqnoTLJm+IAr/fQ6XtbJVzH1sxl+LR+aa2DbOBx8+bmuDOql8eYkS+hKJ+MQaCcNYG4MRDYW9Mz0NrR5EGwnEcvuiFl6q1gfVU+tiU/LNLYY5V6IHhVrgHl2qTQAN6BD4SLfH3yAXpaS+yh1T4GtYxXJ6F5JJEXoE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789024397; c=relaxed/simple; bh=gpk4QCTkMMoVEQ2hU/PY3Bgu//ErkeN2hdFFYL0E0/g=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ECaVFFcbau+OWNuKR6HbXrYusQocoxROACuZh5dDud7aqu3Bdf2O/9wsO/8Rxjm8eIWoqF4Ftjzl28lczlfkz5cBC/twiE1+DrQMc60AhqxHILnwBoZ4YNfMMQd8FGWaJY7T1frq92KDCmGPpiQsO3JUCRr+PjK22Hq674/Ke1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xNNGKL/O; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xNNGKL/O" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4995b0343c1so91901775e9.3 for ; Thu, 10 Sep 2026 00:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789024392; x=1789629192; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=udAblsmxBxBfrNPUP96gC45YbWeS/a2NvUFAIRjIBU8=; b=xNNGKL/OgvZfEgwpuu83dNNxocsmP92+qtaHINbzckwCulhu9S1M9qfYxYHPdec4RH ZYOAXEX42LKanydu6VbxIFT4FcjEOXVGs/B7CEzCY13293U+AIe9kYYm1MWfQK9ihfr1 07jHqlcGgOWKXmKcLxTpaWOSVq9fgtkBiLfBXQtzv0eRTBbhdUyfz1dNB149+0bqmofn 08d4QpRrvBAsg2dvhG6J4W+CnhdNVtkSbSS5V7r0N1yj5qs8dIZueMA3/XsRX8FW1Th+ 2T2xahvLdBndziMdeyrd+4jUU/4YfgKmnTCAcZbuyhEBTYV4qF7PhQKJZNjczEvryGEc mqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789024392; x=1789629192; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=udAblsmxBxBfrNPUP96gC45YbWeS/a2NvUFAIRjIBU8=; b=bUVVmaEGGGTVMx50jk25sCjc7BruIBRWA+nJa8HJEVjz5y6QGEto8Aktu+ya/FQaJa x3JKl5JtPOeY7Z2F/XmS+7gFjr9GzSgZHJjrHDdPiSOHI4/4WeRwKEb0/IJCarjqnA/3 PInmjYj3ZuRmKunPaa9iUYCOfNGmRcjHwE0Ul1XqLznPi4289gPvnV8mkfVrnrOgcpjT G4FdnZnX1VryDN1DRnEyo3NASXZICfrbsqgZesu1DGPUV6/7cWul+hYJnvjX4nBfzs0R 1afikIqnvX7c+8VpN0V85VWdUZDn/e6hYtZogrRwpaoZCNJfbezXuqsn/Cdt24Yp0xrQ q4Ww== X-Forwarded-Encrypted: i=1; AKwUvBx16oH2HYs0dXsnZAjHUaDGqZjo82umWCrHP7z1yHRxhS2RFcVQAtXJnFSBazcNndzNTeTFQzl2KSM=@vger.kernel.org X-Gm-Message-State: AFuF++nUtXJ9OWyUY3CWCJTizMBoxySk9rxydgN4Z/XYrBu0OIDVkbUD ZgJ03HDbswrxu+Wh1nRrw4Gg1PIr2M4HbghmyiaUJhF30XyhA5hOzJADDg+yL6EHU0U= X-Gm-Gg: AYBFou3FcS57Hifs4M9sAnHUa1iAievBgJVXcjnYlqSc8fXfon+3kcghE/9rGLjLDsJ 5zdraIlLAlY32S/ylJtlbbAeuiucUuVG4ZiXka0h0BHkl5ZkH2OTWVXv/wYjJmYgjFC2evtQIDq qKKd4DO29PdSMQVulq+KmLrSAkzt9FM124wOQWpzuZ2q5AX5i1ctL5rNB7DKp8vgvF7D/5UW9S6 A/pAGvTJZpH+7aiHCDyDnK8Dw8fVGxsJMPOg4XbpCZVajxx5JVMKYvaM+psxGOgDP0/WtJzQMKX VdSe3arjKRioxUWZOayjwHwaYIjj09LjJlwE5nBsxGsdZvCUDwuuJC/W1n9ngmoQzHsWfQih98z JffrOz4doAAUalh8IEASu5D7pHmAwoghb/4vHEraRsJW87oHSNrmYu8Jliz0/OX5bcLH3MSCwwW uwzdX9SeeHgoqeXHaEeenvxHP5ftJAggWE6d3evamihDHe2jIIQBgPEIHPsAC6qfH3bOs9rluIc 1VmRltiqfu4ordQnlyO0XQup/Z0bZu9iY+T3gb4W9QRnzitvUV8xA== X-Received: by 2002:a05:600c:4e4c:b0:499:621a:2ec2 with SMTP id 5b1f17b1804b1-49cf8206e4dmr412212555e9.3.1789024392371; Thu, 10 Sep 2026 00:13:12 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:3caf:d840:c911:29a9? ([2a01:e0a:106d:1080:3caf:d840:c911:29a9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26be64a5sm49914055e9.6.2026.09.10.00.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Sep 2026 00:13:09 -0700 (PDT) Message-ID: Date: Thu, 10 Sep 2026 09:13:06 +0200 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/4] mmc: meson-gx: enable the bus pipeline clock on T7 To: Lucas Tanure , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Stephen Boyd Cc: Brian Masney , Chuan Liu , Jian Hu , Ronald Claveau , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260905153234.133217-1-tanure@linux.com> <20260905153234.133217-3-tanure@linux.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260905153234.133217-3-tanure@linux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/5/26 17:32, Lucas Tanure wrote: > On the T7 SoC, the bus path between the SD/eMMC controllers and the > NIC_MATRIX fabric goes through a pipeline stage inserted by the hardware > design to help timing closure. The stage has its own gate clock and, > when that clock is disabled, a controller that starts a DMA transfer can > never complete it, hanging the storage devices and, from there, the > whole system. > > Add a dedicated match data for the amlogic,t7-mmc compatible that makes > the driver claim and enable the "pipeline" clock for as long as the > device is bound. > > The clock is deliberately not optional: the hardware cannot do DMA > without it, and failing the probe with a clear error is preferable to > booting and hitting an undiagnosable DMA hang later. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Lucas Tanure > --- > drivers/mmc/host/meson-gx-mmc.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 694bb443d5f3..c0f1e929fc13 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -139,6 +139,7 @@ struct meson_mmc_data { > unsigned int always_on; > unsigned int adjust; > unsigned int irq_sdio_sleep; > + bool has_pipeline_clk; > }; > > struct sd_emmc_desc { > @@ -1204,6 +1205,15 @@ static int meson_mmc_probe(struct platform_device *pdev) > if (IS_ERR(core_clk)) > return PTR_ERR(core_clk); > > + if (host->data->has_pipeline_clk) { > + struct clk *pipe_clk; > + > + pipe_clk = devm_clk_get_enabled(&pdev->dev, "pipeline"); > + if (IS_ERR(pipe_clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(pipe_clk), > + "missing pipeline clock\n"); > + } > + > ret = meson_mmc_clk_init(host); > if (ret) > return ret; > @@ -1322,12 +1332,22 @@ static const struct meson_mmc_data meson_axg_data = { > .irq_sdio_sleep = CLK_V3_IRQ_SDIO_SLEEP, > }; > > +static const struct meson_mmc_data meson_t7_data = { > + .tx_delay_mask = CLK_V3_TX_DELAY_MASK, > + .rx_delay_mask = CLK_V3_RX_DELAY_MASK, > + .always_on = CLK_V3_ALWAYS_ON, > + .adjust = SD_EMMC_V3_ADJUST, > + .irq_sdio_sleep = CLK_V3_IRQ_SDIO_SLEEP, > + .has_pipeline_clk = true, > +}; > + > static const struct of_device_id meson_mmc_of_match[] = { > { .compatible = "amlogic,meson-gx-mmc", .data = &meson_gx_data }, > { .compatible = "amlogic,meson-gxbb-mmc", .data = &meson_gx_data }, > { .compatible = "amlogic,meson-gxl-mmc", .data = &meson_gx_data }, > { .compatible = "amlogic,meson-gxm-mmc", .data = &meson_gx_data }, > { .compatible = "amlogic,meson-axg-mmc", .data = &meson_axg_data }, > + { .compatible = "amlogic,t7-mmc", .data = &meson_t7_data }, > {} > }; > MODULE_DEVICE_TABLE(of, meson_mmc_of_match); Reviewed-by: Neil Armstrong Thanks, Neil